Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release PR #3647

Merged
merged 19 commits into from
Nov 14, 2024
Merged

Release PR #3647

merged 19 commits into from
Nov 14, 2024

Conversation

boxadesign
Copy link
Contributor

What

<What is this PR doing, e.g. implementations, algorithms, etc.?>

Why

<Why is this change happening, e.g. goals, use cases, stories, etc.?>

Tick or delete as appropriate:

Workflow

Reviewing help

  • Explains how to test locally, including how to set up appropriate data
  • Includes screenshot(s) - ideally before and after, but at least after
  • Documentation has been updated as necessary
  • Where a PR contains code changes developed or maintained by multiple squads a representative from those squads should review the PR.

Housekeeping

  • Added all new environment variables to Vault.
  • Cleaned up old feature flags
  • Upgraded any vulnerable dependencies.
  • I have updated security dependencies
  • Python requirements have been re-compiled.
  • I have checked that my PR is using the latest package versions of: great-components, directory-constants, directory-healthcheck, directory-validators, directory-components, directory-api-client, directory-ch-client, django-staff-sso-client, directory-forms-api-client, directory-sso-api-client, sigauth

Security

  • Frontend assets have been re-compiled
  • Checked for potential security vulnerabilities
  • Ensured any sensitive data is handled appropriately

Performance

  • Evaluated the performance impact of the changes
  • Ensured that changes do not negatively affect application scalability.

Merging

  • This PR can be merged by reviewers. (If unticked, please leave for the author to merge)

timothyPatterson and others added 16 commits November 8, 2024 15:53
@timothyPatterson
redirects for migration of cms content from great-international-ui to…
fe4cc0b 
… great-cms
@stuart-mindt
Merge branch 'develop' into feature-IGUK-633-international-redirects
702f3ef
@stuart-mindt
Feature IGUK-499 resume EYB triage when incomplete on login (#3621)
e4a6c1a 
* IGUK-499 Resume EYB triage when users log back in if incomplete
@stuart-mindt
IGUK-633 Removing links to old investment opportunities
0115fb9
@stuart-mindt
Merge branch 'develop' into feature-IGUK-633-international-redirects
dc982fd
@ecbm
Update market guide list copy
ee6e1b1
@ecbm
Merge branch 'develop' into feature-ET-597-new-market-guide-list-copy
c364455
@ecbm
Merge pull request #3640 from uktrade/feature-ET-597-new-market-guide…
32d3545 
…-list-copy

Update market guide list copy
@stuart-mindt
feature IGUK-422 EYB triage hiring choices update (#3638)
fc8f0d7 
* feature IGUK-422 EYB triage hiring choices update
@ecbm
minor content changes and UI tweaks
ee6b414
@ecbm
Merge pull request #3643 from uktrade/patch-ET-597-market-guide-list-…
2c29f34 
…content-fix

Minor content changes and UI tweaks
@ecbm
Replace filter market guides copy
fe17400
@ecbm
Merge pull request #3644 from uktrade/patch-ET-597-replace-filter-mar…
12955e3 
…ket-guides-copy

Replace filter market guides copy
@FoxJamie16
Feature grtlv 330 fe add design system footer component in great (#3642)
9a29a2d 
* grtlv-330 domestic, international and microsite footers now use design system footer in line with figma

* Footer added to login/signup pages

* great-design-system package bump for link focus style override

* design feedback - link order changed, copyright container padding removed, underline hover added to links

* Export support moved to first link

* small readability change in block ordering
@boxadesign
Fix column layout on rtl
f284bc4
@boxadesign
Merge pull request #3646 from uktrade/bug-GRTLV-405-campaign-site-rtl…
5e4a487 
…-grid

GRTLV-405 - Fix column layout on rtl for campaign sites
@boxadesign boxadesign requested a review from a team as a code owner November 14, 2024 12:29
@boxadesign @FoxJamie16
Bug grtlv 404 clean caching issue on logged out learn articles and hc…
441c95b 
…sat (#3648)

* csrf_protect decorator added to detailpage serve method, and small csrf fetch change to use django recommended method

* test fix ignore csrf

---------

Co-authored-by: Jamie Fox <[email protected]>
@timothyPatterson timothyPatterson merged commit fa701ab into master Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoxJamie16 FoxJamie16 FoxJamie16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@boxadesign @FoxJamie16 @timothyPatterson @stuart-mindt @ecbm