EYB accessibility #3174
Merged
EYB accessibility #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyPatterson
force-pushed
the
EYB-40-43-accessibility
branch
from
b6bace1
to
9dc7e6c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3174 +/- ##
========================================
Coverage 95.33% 95.33%
========================================
Files 209 209
Lines 13573 13573
========================================
Hits 12940 12940
Misses 633 633
|
Refactor expand your business js import into base.html
Modify triage header to remove question title and refactor question title into each form. Ensure labels/legends are contained with form / fieldset elements. Override govuk-fieldset__heading to align with International fonts. Conditional display of field.label in form_field.html to remove redundant markup where label is an empty string.
timothyPatterson
force-pushed
the
EYB-40-43-accessibility
branch
from
50b6480
to
9aa764f
Compare
stuart-mindt
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two findings from an accessibility audit: 1) align legends and labels with GOVUK form guidance for pages with single questions, 2) add focus to autocomplete input element when the user presses ESC on the dropdown list. This is a known issue with the autocomplete library we are using - alphagov/accessible-autocomplete#692
Workflow
Reviewing help
Merging