Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic CreateRow component #2160

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Generic CreateRow component #2160

merged 1 commit into from
Apr 24, 2024

Conversation

ujh
Copy link
Owner

@ujh ujh commented Apr 24, 2024

Separate the generic bits from the ink specific ones

Separate the generic bits from the ink specific ones
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 11.42857% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 72.57%. Comparing base (ab4afba) to head (908c6c3).

Files Patch % Lines
...ript/src/admin/components/clustering/CreateRow.jsx 9.09% 20 Missing ⚠️
...min/micro-clusters/createMacroClusterAndAssign.jsx 9.09% 10 Missing ⚠️
...ascript/src/admin/micro-clusters/ignoreCluster.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2160   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files         242      244    +2     
  Lines        4025     4025           
  Branches      157      157           
=======================================
  Hits         2921     2921           
  Misses       1086     1086           
  Partials       18       18           
Flag Coverage Δ
javascript 59.33% <11.42%> (ø)
ruby 79.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ujh ujh merged commit 9a9d2ad into master Apr 24, 2024
6 of 7 checks passed
@ujh ujh deleted the extract-create-row branch April 24, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant