Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start making the code generic by passing in functions #2159

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

ujh
Copy link
Owner

@ujh ujh commented Apr 24, 2024

No description provided.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 72.57%. Comparing base (3650dad) to head (b73bba3).

Files Patch % Lines
.../src/admin/components/clustering/BrandSelector.jsx 60.00% 4 Missing ⚠️
...src/admin/components/clustering/LoadingOverlay.jsx 40.00% 2 Missing and 1 partial ⚠️
.../src/admin/micro-clusters/DisplayMacroClusters.jsx 75.00% 1 Missing ⚠️
.../src/admin/micro-clusters/DisplayMicroClusters.jsx 50.00% 1 Missing ⚠️
...javascript/src/admin/micro-clusters/GenericApp.jsx 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2159      +/-   ##
==========================================
+ Coverage   72.55%   72.57%   +0.01%     
==========================================
  Files         238      242       +4     
  Lines        4023     4025       +2     
  Branches      157      157              
==========================================
+ Hits         2919     2921       +2     
  Misses       1086     1086              
  Partials       18       18              
Flag Coverage Δ
javascript 59.33% <79.16%> (+0.05%) ⬆️
ruby 79.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ujh ujh merged commit 080ae94 into master Apr 24, 2024
7 checks passed
@ujh ujh deleted the more-generic-code branch April 24, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant