Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure api calls #2158

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Restructure api calls #2158

merged 2 commits into from
Apr 24, 2024

Conversation

ujh
Copy link
Owner

@ujh ujh commented Apr 24, 2024

No description provided.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 72.55%. Comparing base (b83bbe8) to head (db7d609).

Files Patch % Lines
...vascript/src/admin/micro-clusters/macroClusters.js 18.18% 9 Missing ⚠️
...pt/src/admin/components/clustering/EntriesList.jsx 14.28% 6 Missing ⚠️
...ipt/src/admin/micro-clusters/CollectedInksList.jsx 0.00% 3 Missing ⚠️
...ipt/src/admin/components/clustering/SearchLink.jsx 50.00% 1 Missing ⚠️
app/javascript/src/admin/micro-clusters/App.jsx 66.66% 1 Missing ⚠️
...vascript/src/admin/micro-clusters/microClusters.js 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2158      +/-   ##
==========================================
- Coverage   72.62%   72.55%   -0.07%     
==========================================
  Files         237      238       +1     
  Lines        4018     4023       +5     
  Branches      156      157       +1     
==========================================
+ Hits         2918     2919       +1     
- Misses       1082     1086       +4     
  Partials       18       18              
Flag Coverage Δ
javascript 59.27% <53.33%> (-0.14%) ⬇️
ruby 79.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ujh ujh merged commit 3650dad into master Apr 24, 2024
5 of 7 checks passed
@ujh ujh deleted the restructure-api-calls branch April 24, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant