Use generic entries and grouped_entries #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use `collected_inks` and `grouped_collected_inks`, but instead convert to `entries` and `grouped_entries` as early as possible. Then the generic clustering code can be extracted later on and be reused.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2155 +/- ##
==========================================
- Coverage 71.74% 71.73% -0.02%
==========================================
Files 236 236
Lines 4010 4019 +9
Branches 156 156
==========================================
+ Hits 2877 2883 +6
- Misses 1115 1118 +3
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use
collected_inksandgrouped_collected_inks, but instead convert toentriesandgrouped_entriesas early as possible. Then the generic clustering code can be extracted later on and be reused.