Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor clustering app #2153

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Refactor clustering app #2153

merged 6 commits into from
Apr 23, 2024

Conversation

ujh
Copy link
Owner

@ujh ujh commented Apr 23, 2024

First step towards a more generic version of the clustering app.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.74%. Comparing base (dde8203) to head (77e251a).

Files Patch % Lines
...avascript/src/admin/micro-clusters/loadClusters.js 94.44% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2153      +/-   ##
==========================================
+ Coverage   71.58%   71.74%   +0.16%     
==========================================
  Files         234      236       +2     
  Lines        4012     4010       -2     
  Branches      159      156       -3     
==========================================
+ Hits         2872     2877       +5     
+ Misses       1120     1115       -5     
+ Partials       20       18       -2     
Flag Coverage Δ
javascript 56.86% <95.00%> (+0.43%) ⬆️
ruby 79.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ujh ujh force-pushed the refactor-clustering-app branch from f1ccb8a to 77e251a Compare April 23, 2024 14:21
@ujh ujh merged commit 0cc1c5f into master Apr 23, 2024
7 checks passed
@ujh ujh deleted the refactor-clustering-app branch April 23, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant