Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brands API endpoint #1387

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Brands API endpoint #1387

merged 1 commit into from
Jan 24, 2023

Conversation

ujh
Copy link
Owner

@ujh ujh commented Jan 24, 2023

First endpoint of the new JSON API. Super simple, as it just returns brand names.

First endpoint of the new JSON API. Super simple, as it just returns
brand names.
@ujh
Copy link
Owner Author

ujh commented Jan 24, 2023

Relates to #1361

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 62.96% // Head: 63.40% // Increases project coverage by +0.43% 🎉

Coverage data is based on head (3ecaa36) compared to base (586aee0).
Patch coverage: 93.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
+ Coverage   62.96%   63.40%   +0.43%     
==========================================
  Files         145      147       +2     
  Lines        2954     2962       +8     
  Branches       94       94              
==========================================
+ Hits         1860     1878      +18     
+ Misses       1085     1075      -10     
  Partials        9        9              
Flag Coverage Δ
javascript 27.60% <ø> (ø)
ruby 79.07% <93.33%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/controllers/brands_controller.rb 33.33% <0.00%> (+9.80%) ⬆️
app/controllers/api/v1/base_controller.rb 100.00% <100.00%> (ø)
app/controllers/api/v1/brands_controller.rb 100.00% <100.00%> (ø)
app/models/brand_cluster.rb 64.28% <0.00%> (+3.57%) ⬆️
app/serializers/brand_cluster_serializer.rb 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ujh ujh merged commit 96b61f5 into master Jan 24, 2023
@ujh ujh deleted the brands-api-endpoint branch January 24, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant