Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move JSON API endpoints #1361

Open
ujh opened this issue Jan 18, 2023 · 1 comment
Open

Move JSON API endpoints #1361

ujh opened this issue Jan 18, 2023 · 1 comment
Milestone
API cleanup

Comments

@ujh
Copy link
Owner

ujh commented Jan 18, 2023

To make them easier to find, let's move all JSON API endpoints from wherever they to /api/v1.

Benefits:

  • Using rails routes it will be easy to see what's there
  • Clean up of specialized endpoints (e.g. /accounts.json comes to mind)
@ujh ujh added this to FPC backlog Jan 18, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in FPC backlog Jan 18, 2023
@ujh ujh moved this from 🆕 New to 🔖 Ready in FPC backlog Jan 18, 2023
@ujh ujh mentioned this issue Jan 18, 2023
Open
@ujh ujh moved this from 🔖 Ready to 🏗 In progress in FPC backlog Jan 24, 2023
This was referenced Jan 24, 2023
Merged
Merged
Merged
@ujh
Copy link
Owner Author

ujh commented Jan 24, 2023

/api/v1/inks, /api/v1/lines, and /api/v1/brands` probably don't make sense as separate endpoints. All their requirements could be merged into one general ink search endpoint.

@ujh ujh mentioned this issue Jan 24, 2023
Open
@ujh ujh added this to FPC board Jul 3, 2023
@ujh ujh moved this to Todo in FPC board Jul 3, 2023
@ujh ujh added this to the API cleanup milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
FPC board
Status: Todo
FPC backlog
Status: 🏗 In progress
Milestone
API cleanup
Development

No branches or pull requests
1 participant
@ujh