Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts to build on both Gaea-C5 and C6 #995

Merged
merged 12 commits into from
Nov 15, 2024

Conversation

DavidBurrows-NCO
Copy link
Contributor

@DavidBurrows-NCO DavidBurrows-NCO commented Oct 21, 2024

DESCRIPTION OF CHANGES:

The Gaea-C5 OS upgrade changed the version numbers for stack-intel and stack-cray-mpich. This PR updates the module files to point to the new version numbers.

In addition, following the ufs-wx-model PR2448 for Gaea-C6 upgrade, target is set to either gaeac5 and gaeac6, and separate module files are created for each.

TESTS CONDUCTED:

Cloned and built on Gaea-C5 and C6.

Standard tests

  • Compile branch on all Tier 1 machines using Intel. Done on WCOSS2, Jet, Hera, Orion and Hercules using 82f998c.
  • Test the link_fixdirs.sh script on all Tier 1 machines. Done on WCOSS2, Jet, Hera, Orion and Hercules using 82f998c.

DEPENDENCIES:

NA

DOCUMENTATION:

NA

ISSUE:

References NOAA-EMC/global-workflow issue #3011

Resolves #994

@DavidBurrows-NCO
Copy link
Contributor Author

Hello @GeorgeGayno-NOAA I have included updates for building ufs-utils in a container provided by @mark-a-potts. This is work being coordinated with @aerorahul (@WalterKolczynski-NOAA added since Rahul is on leave) and references NOAA-EMC/global-workflow Issue #3025.
For links to the fix directories, we don't want to have the fix directories in the container so did not update link_fixdirs.sh.
Please let me know if including the container build is okay, and if so, how we should handle link_fixdirs.sh. Maybe a warning message?
Thanks!

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidBurrows-NCO - I had already approved this PR, but I see you are making more changes. I will re-review when you are done.

@DavidBurrows-NCO
Copy link
Contributor Author

@GeorgeGayno-NOAA Sorry about that! Code is finalized and is consistent with other global-workflow submodules. Thanks.

@GeorgeGayno-NOAA
Copy link
Collaborator

@DavidBurrows-NCO - 'develop' was updated this morning. Please merge these changes to your branch.

@DavidBurrows-NCO
Copy link
Contributor Author

@GeorgeGayno-NOAA I updated my fork and tested a clone/build on C6 successfully.

@GeorgeGayno-NOAA
Copy link
Collaborator

@DavidBurrows-NCO - 'develop' was updated again. Please merge these updates to your branch and retest. Then, I will merge your changes. Thanks.

@DavidBurrows-NCO
Copy link
Contributor Author

@GeorgeGayno-NOAA All set. Thanks.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while reviewing gfs-utils, I came across this PR as well for Gaea C5 C6. Some comments.

modulefiles/build.container.intel.lua Outdated Show resolved Hide resolved
modulefiles/build.container.intel.lua Show resolved Hide resolved
modulefiles/build.container.intel.lua Show resolved Hide resolved
modulefiles/build.container.intel.lua Outdated Show resolved Hide resolved
@GeorgeGayno-NOAA
Copy link
Collaborator

@aerorahul, thanks for your review. Any further comments?

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@aerorahul
Copy link
Contributor

@aerorahul, thanks for your review. Any further comments?

nopes. look good. thanks for checking.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 5b2bfa3 into ufs-community:develop Nov 15, 2024
4 checks passed
@DavidBurrows-NCO
Copy link
Contributor Author

Thanks @GeorgeGayno-NOAA @aerorahul @mark-a-potts Have a good weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ufs_utils fails to build on Gaea-C5 after OS upgrade
4 participants