-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scripts to build on both Gaea-C5 and C6 #995
Update scripts to build on both Gaea-C5 and C6 #995
Conversation
Updates for building with containers
Hello @GeorgeGayno-NOAA I have included updates for building ufs-utils in a container provided by @mark-a-potts. This is work being coordinated with @aerorahul (@WalterKolczynski-NOAA added since Rahul is on leave) and references NOAA-EMC/global-workflow Issue #3025. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidBurrows-NCO - I had already approved this PR, but I see you are making more changes. I will re-review when you are done.
@GeorgeGayno-NOAA Sorry about that! Code is finalized and is consistent with other global-workflow submodules. Thanks. |
@DavidBurrows-NCO - 'develop' was updated this morning. Please merge these changes to your branch. |
@GeorgeGayno-NOAA I updated my fork and tested a clone/build on C6 successfully. |
@DavidBurrows-NCO - 'develop' was updated again. Please merge these updates to your branch and retest. Then, I will merge your changes. Thanks. |
@GeorgeGayno-NOAA All set. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while reviewing gfs-utils, I came across this PR as well for Gaea C5 C6. Some comments.
removed unnecessary modules
@aerorahul, thanks for your review. Any further comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
nopes. look good. thanks for checking. |
Thanks @GeorgeGayno-NOAA @aerorahul @mark-a-potts Have a good weekend. |
DESCRIPTION OF CHANGES:
The Gaea-C5 OS upgrade changed the version numbers for stack-intel and stack-cray-mpich. This PR updates the module files to point to the new version numbers.
In addition, following the ufs-wx-model PR2448 for Gaea-C6 upgrade, target is set to either gaeac5 and gaeac6, and separate module files are created for each.
TESTS CONDUCTED:
Cloned and built on Gaea-C5 and C6.
Standard tests
link_fixdirs.sh
script on all Tier 1 machines. Done on WCOSS2, Jet, Hera, Orion and Hercules using 82f998c.DEPENDENCIES:
NA
DOCUMENTATION:
NA
ISSUE:
References NOAA-EMC/global-workflow issue #3011
Resolves #994