Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(text-style): merge all packages into text-style #6001

Merged
merged 11 commits into from
Jan 8, 2025

Conversation

nperez0111
Copy link
Contributor

@nperez0111 nperez0111 commented Jan 7, 2025

Changes Overview

This reorganizes all of the extensions based on the text-style extension to be within the @tiptap/extension-text-style package. With the old packages having re-exports to sub dir exports like the color extension now is just:

// @ts-ignore
import { Color, ColorOptions } from '@tiptap/extension-text-style/color'

export { Color, ColorOptions }

export default Color

As with the reorganization of table-kit, there is now a textStyle kit, which neatly packages all of the textStyle extensions into one easy extension.

This also introduces two new textStyle extensions, backgroundColor, and lineHeight for managing those CSS properties respectively.

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit f2149cc
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/677d6256a2cce50008febf16
😎 Deploy Preview https://deploy-preview-6001--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: f2149cc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 7, 2025

Open in Stackblitz

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@6001

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@6001

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@6001

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@6001

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@6001

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@6001

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@6001

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@6001

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@6001

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@6001

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@6001

@tiptap/extension-collaboration-cursor

npm i https://pkg.pr.new/@tiptap/extension-collaboration-cursor@6001

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@6001

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@6001

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@6001

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@6001

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@6001

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@6001

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@6001

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@6001

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@6001

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@6001

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@6001

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@6001

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@6001

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@6001

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@6001

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@6001

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@6001

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@6001

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@6001

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@6001

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@6001

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@6001

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@6001

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@6001

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@6001

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@6001

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@6001

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@6001

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@6001

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@6001

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@6001

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@6001

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@6001

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@6001

@tiptap/extension-utils

npm i https://pkg.pr.new/@tiptap/extension-utils@6001

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@6001

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@6001

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@6001

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@6001

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@6001

@tiptap/static-renderer

npm i https://pkg.pr.new/@tiptap/static-renderer@6001

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@6001

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@6001

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@6001

commit: f2149cc

Comment on lines +1 to +2
// @ts-ignore
import { Color, ColorOptions } from '@tiptap/extension-text-style/color'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that we only load from the sub dir export, meaning the minimum amount of code will be loaded (it will be pretty much the same as what the package was exporting before)

@nperez0111 nperez0111 requested a review from bdbch January 7, 2025 17:29
Copy link
Member

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nperez0111 nperez0111 merged commit 0b4981c into next Jan 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants