fix(react): reorder handleSelectionUpdate callback (#5982)

ueberdosis · Jan 3, 2025 · dac7fd2 · dac7fd2
1 parent 5370cbe
commit dac7fd2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/early-parrots-carry.md b/.changeset/early-parrots-carry.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/react": patch
+---
+
+Resolves #5870 by re-ordering executation of selectionUpdate handler
diff --git a/packages/react/src/ReactNodeViewRenderer.tsx b/packages/react/src/ReactNodeViewRenderer.tsx
@@ -141,7 +141,6 @@ export class ReactNodeView<
     const { className = '' } = this.options
 
     this.handleSelectionUpdate = this.handleSelectionUpdate.bind(this)
-    this.editor.on('selectionUpdate', this.handleSelectionUpdate)
 
     this.renderer = new ReactRenderer(ReactNodeViewProvider, {
       editor: this.editor,
@@ -150,6 +149,7 @@ export class ReactNodeView<
       className: `node-${this.node.type.name} ${className}`.trim(),
     })
 
+    this.editor.on('selectionUpdate', this.handleSelectionUpdate)
     this.updateElementAttributes()
   }