Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHC 9.8 backwards compatibility (WIP) #2380

Merged
merged 3 commits into from
Oct 17, 2024
Merged

GHC 9.8 backwards compatibility (WIP) #2380

merged 3 commits into from
Oct 17, 2024

Conversation

gergoerdi
Copy link
Contributor

  • GHC-9.8 compatibility: Uniques contain Ints instead of Word64s.
  • GHC-9.8 compatibility: import foldl' from Data.List
  • GHC-9.8 compatibility: Different module names for Foldable and Real

@gergoerdi
Copy link
Contributor Author

This is basically the "easy" part of #2379. I'd love to hear suggestions on how to handle the "hard" (actual API differences) part.

@gergoerdi gergoerdi mentioned this pull request Oct 15, 2024
Open
5 tasks
@gergoerdi
Copy link
Contributor Author

OK so this new version avoids using CPP and basically just arranges for a more centralized way of making a separate GHC 9.8 branch.

@gergoerdi gergoerdi marked this pull request as ready for review October 17, 2024 06:27
@gergoerdi
Copy link
Contributor Author

I've removed the draft status because the current two commits are good to go

facundominguez
facundominguez approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@facundominguez facundominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gergoerdi!

@facundominguez facundominguez merged commit cd819f1 into ucsd-progsys:develop Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundominguez facundominguez facundominguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gergoerdi @facundominguez