Disable environment reduction by default #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this ! Shall I merge? |
ranjitjhala
approved these changes
Oct 24, 2021
facundominguez
commented
Oct 25, 2021
facundominguez
force-pushed
the
fd/disable-environment-reduction
branch
from
2034749 to
1c2ea7e
Compare
|
Now this should be ready to merge. (Had a flipped boolean before) |
|
@ranjitjhala, @nikivazou, Ping! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment reduction can break the tree-like invariant necessary by PLE, which can cause LH to decide incorrectly on the validity of constraints.
Therefore, this PR makes not running environment reduction the default.
We can revert this after ucsd-progsys/liquid-fixpoint#496 is fixed.