Typeclass with minor fixes #1641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: Typeclass updates
|
Thanks @yiyunliu!!!! |
|
Yeah I think it would be more productive if you review it later. It is a
lot of commits behind from develop so I want to merge with HEAD at some
point. I'll look at the test result and fix the issues as well. I'll let
you know once I'm ready.
…On 4/7/20 3:02 PM, Niki Vazou wrote:
Thanks @yiyunliu <https://github.com/yiyunliu>!!!!
Does the WIP tag mean that I should not start the review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1641 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIVB35DR3GPFFGVDCU5N6JTRLN2CVANCNFSM4MDINHKA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type class implementation for the paper with better error messages and bug fixes. Some known issues include unhandled elaboration cases such as types of the form
Maybe {v : a | P(a)}.