Fix tidySymbol to not drop arg-id
#659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundominguez
approved these changes
Nov 4, 2023
| @@ -518,7 +518,7 @@ tidySymbol s | |||
| | otherwise = s'' | |||
| where | |||
| s' = unPrefixSymbol kArgPrefix s | |||
| s'' = unPrefixSymbol symSepName . unPrefixSymbol hvarPrefix $ s' | |||
| s'' = consSym '$' . unPrefixSymbol symSepName . unSuffixSymbol . unPrefixSymbol hvarPrefix $ s' | |||
There was a problem hiding this comment.
I'm out of my depth here, but I just wanted to suggest adding a comment to tidySymbol explaining what it is meant to do.
There was a problem hiding this comment.
And similar suggestion for the other functions modified in the PR. Alternatively, perhaps the source code could be made more self explanatory if the structure of the symbols is explained in a comment.
|
Excellent suggestion @facundo, will do!
…On Sat, Nov 4, 2023 at 8:45 AM Facundo Domínguez ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Language/Fixpoint/Types/Names.hs
<https://urldefense.com/v3/__https://github.com/ucsd-progsys/liquid-fixpoint/pull/659*discussion_r1382420428__;Iw!!Mih3wA!HmfM8YSx-cb_SZp0RiSayMOc2wUkoIWw_cQ1zJDc2Rqli0zCuv2yOroFyFIzaQvfwFHzOIKZd4D-vS0uXYKXC19x$>
:
> @@ -518,7 +518,7 @@ tidySymbol s
| otherwise = s''
where
s' = unPrefixSymbol kArgPrefix s
- s'' = unPrefixSymbol symSepName . unPrefixSymbol hvarPrefix $ s'
+ s'' = consSym '$' . unPrefixSymbol symSepName . unSuffixSymbol . unPrefixSymbol hvarPrefix $ s'
And similar suggestion for the other functions modified in the PR.
Alternatively, perhaps the source code could be made more self explanatory
if the structure of the symbols is explained in a comment.
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/ucsd-progsys/liquid-fixpoint/pull/659*discussion_r1382420428__;Iw!!Mih3wA!HmfM8YSx-cb_SZp0RiSayMOc2wUkoIWw_cQ1zJDc2Rqli0zCuv2yOroFyFIzaQvfwFHzOIKZd4D-vS0uXYKXC19x$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAMS4OGMADGP5S5JEHMD2FTYCZPKDAVCNFSM6AAAAAA65UKPBWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJTHAYTIMRXGA__;!!Mih3wA!HmfM8YSx-cb_SZp0RiSayMOc2wUkoIWw_cQ1zJDc2Rqli0zCuv2yOroFyFIzaQvfwFHzOIKZd4D-vS0uXT1Zlrtf$>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unKArgSymbolfor matching qual-patternsfixes #658