Follow stan hint, explicit fixity (default is infixl 9). #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (=>>) :: Monad m => m b -> (b -> m a) -> m b | ||
| (=>>) m f = m >>= (\x -> f x >> return x) | ||
|
|
||
| infixl 9 <<= | ||
| (<<=) :: Monad m => (b -> m a) -> m b -> m b | ||
| (<<=) = flip (=>>) |
There was a problem hiding this comment.
I would think these should be removed from here. And replaced in the code with >>= and =<<.
There was a problem hiding this comment.
Looks like (=>>) :: Monad m => m b -> (b -> m a) -> m b and (<<=) are not used.
There was a problem hiding this comment.
Had a quick peek at liquidhaskell. Each operator is only used once there, (=>>) in Language.Haskell.Liquid.Constraint.Fresh and (<<=) in Language.Haskell.Liquid.Constraint.Generate. Perhaps those modules should define such an operator privately or use the inline equivalent and we remove them from liquid-fixpoint?
Remove BangPatterns.
philderbeast
force-pushed
the
stan/missing-fixity
branch
from
5fcbfe9 to
91fe98c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #610. I'm putting this up here as-is so please label with WIP. I'd like some feedback on which fixities to go with. Are there some that shouldn't be associative? Could some of these be replaced with existing operators we pull in from elsewhere?
https://kowainik.github.io/posts/fixity#standard-examples
For now I've just been explicit but with the default
infixl 9.