Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic title #488

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dynamic title #488

wants to merge 2 commits into from
+19 −0

Conversation

ariyin
Copy link
Contributor

@ariyin ariyin commented Nov 16, 2024

Changes

Changes the title dynamically so the title reflects which page the user is on.

Type of change

  • New feature (non-breaking change which adds functionality)

Related Issues

#487

@ariyin ariyin requested a review from jamesmwu November 16, 2024 23:50
jamesmwu
jamesmwu requested changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@jamesmwu jamesmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing changes requested! Thanks Jenna

src/pages/Home.jsx Outdated Show resolved Hide resolved
src/components/General/useTitle.jsx Outdated Show resolved Hide resolved
@ariyin ariyin requested a review from jamesmwu November 18, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmwu jamesmwu Awaiting requested review from jamesmwu

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ariyin @jamesmwu