Add new styles for forum creation page #395
Conversation
There was a problem hiding this comment.
Overall, this looks really good. It fits more into the machina implementation and really well done styling. My only concern would be with the image, but I would love to hear your thoughts @bburgess19.
bburgess19
force-pushed
the
forums/forum-create-styling
branch
from
83bbcb2 to
8038528
Compare
| display: inline-block; | ||
| width: 40%; | ||
| box-sizing: border-box; | ||
| background: #eaeaea; |
There was a problem hiding this comment.
Actually like the abstraction here with the new file dedicated to CSS.
| // and add an image preview and trash can to remove the image | ||
| imageField.parentElement.appendChild(trashButton); | ||
| trashButton.addEventListener('click', removeSelectedImage); | ||
| trashButton.imgPreview = imgPreview; |
There was a problem hiding this comment.
Addition of the preview image was well needed and nicely implemented here!
There was a problem hiding this comment.
This looks so sick!
I'm successfully able to make forums, with and without images.
The only thing that is odd is after I make a forum, I get two different "forum successfully created" popups:
This is not an problem for this PR, please add an issue to the backlog about addressing this bug
Closing commentsWe added new styles to the forum creation page. We had to add extra logic to ensure the optional added image is displayed in the forum list.
Issue #418 was created to address this. |
|
Issue Score: Excellent |
Purpose
This PR seeks to add new styling for the forum creation page. Merging of this PR will close #382.
Notes
Here is an example of how the page currently looks:
Also implemented is more styles for the image add/remove button:
