Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Notifications Into Game and Tournament Invites #383

Open
wants to merge 35 commits into
base: dev
Choose a base branch
from

Conversation

ishiii-s
Copy link
Contributor

@ishiii-s ishiii-s commented Dec 2, 2023

This PR addresses #301 to integrate notifications into the functionality to invite users to games and tournaments

@AndrewM131 AndrewM131 modified the milestones: 2023/Wrap-up, 2023/Sprint 3 Dec 3, 2023
@AndrewM131 AndrewM131 linked an issue Dec 3, 2023 that may be closed by this pull request
@henrietta-k henrietta-k requested review from omarelkashef and elizabethli31 and removed request for omarelkashef December 5, 2023 06:55
Copy link
Contributor

@AndrewM131 AndrewM131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you use game invitation, do you mean match invitation as that's what you're using in game invitation. Also, when sending the game invitation or tournament invitation in /admin, it doesn't show up in my inbox unless I manually create a notification. Should this be the case?
Also, your models look correct to me, as well as the code you implemented in views.py, just want some clarification on above.

@ishiii-s
Copy link
Contributor Author

ishiii-s commented Dec 5, 2023

Re: game vs match invitation - everything that refers to a game invitation is an invitation for a match (since a match is a specific instance of playing a game). Sorry if that was confusing Re: showing up in inbox - this code should create a Notification object (as per the Notification class in models.py) automatically after creating an invitation. For now, I'm not concerned with how that is handled by the inbox. LMK if you're still finding an issue considering that. Sorry for any confusion!

When you use game invitation, do you mean match invitation as that's what you're using in game invitation. Also, when sending the game invitation or tournament invitation in /admin, it doesn't show up in my inbox unless I manually create a notification. Should this be the case? Also, your models look correct to me, as well as the code you implemented in views.py, just want some clarification on above.

Re: game vs match invitation - everything that refers to a game invitation is an invitation for a match (since a match is a specific instance of playing a game). Sorry if that was confusing
Re: showing up in inbox - this code should create a Notification object (as per the Notification class in models.py) automatically after creating an invitation. For now, I'm not concerned with how that is handled by the inbox. LMK if you're still finding an issue considering that. Sorry for any confusion!

@AndrewM131
Copy link
Contributor

In the event that it isn't in the inbox, then I'm okay with the current code as I can use the tournament invite and game invite. Thank you for clarifying!

@AndrewM131 AndrewM131 self-requested a review December 5, 2023 20:23
Copy link
Contributor

@AndrewM131 AndrewM131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions were answered, and in the future, it would be a good idea to integrate the notifications into the inbox, but for now, I can access them through /admin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Integrate notifications for game and tournament
4 participants