-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Notifications Into Game and Tournament Invites #383
base: dev
Are you sure you want to change the base?
Conversation
…me into users/integrate-notifs attempting to resolve divergent branch issues for commits
…me into users/integrate-notifs committing notif code in views and models and also fix divergent branch error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you use game invitation, do you mean match invitation as that's what you're using in game invitation. Also, when sending the game invitation or tournament invitation in /admin, it doesn't show up in my inbox unless I manually create a notification. Should this be the case?
Also, your models look correct to me, as well as the code you implemented in views.py, just want some clarification on above.
Re: game vs match invitation - everything that refers to a game invitation is an invitation for a match (since a match is a specific instance of playing a game). Sorry if that was confusing |
In the event that it isn't in the inbox, then I'm okay with the current code as I can use the tournament invite and game invite. Thank you for clarifying! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions were answered, and in the future, it would be a good idea to integrate the notifications into the inbox, but for now, I can access them through /admin
This PR addresses #301 to integrate notifications into the functionality to invite users to games and tournaments