Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/2.4.0 #50

Merged
merged 43 commits into from
Jun 12, 2019
Merged

Dev/2.4.0 #50

merged 43 commits into from
Jun 12, 2019

Conversation

iturgeon
Copy link
Member

@iturgeon iturgeon commented May 28, 2019

Includes:

iturgeon and others added 27 commits January 24, 2019 14:41
Sets default widget height and width to 100%
Consolidates some css
Removes unused mdk-creator.css
… Development Kit' to 'Materia Widget Development Kit'.
* MSCA upgraded to v2.0.0-alpha1
* postinstall and build tasks will no longer build msca assets
…-ids

Make sure empty question and answer IDs have values.
@iturgeon iturgeon marked this pull request as ready for review May 29, 2019 04:47
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it on a few widgets, everything still seems to be installing and building properly.

Seems fine to me.

clpetersonucf
clpetersonucf previously approved these changes Jun 10, 2019
Copy link
Member

@clpetersonucf clpetersonucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with multiple widgets, including the new helper documentation and those that rely on polyfills. Everything looks OK to me. I think it's ready.

Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some widgets' coffeescript appearing to compile differently, which is just going to have to be resolved per widget, everything seems to be good - the only thing I can see is that there are requests to files that don't appear to exist any more. The creator is referencing a mwdk-creator.css which doesn't appear to exist (and manifests as a MIME type error, somehow), and the player tries looking up a main.css which has the same problem.

Copy link
Member

@clpetersonucf clpetersonucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving with new changes.

Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old file references are gone, looks like everything works.

Approved.

@clpetersonucf clpetersonucf merged commit 6f11da3 into master Jun 12, 2019
@clpetersonucf clpetersonucf deleted the dev/2.4.0 branch July 31, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants