-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/2.4.0 #50
Dev/2.4.0 #50
Conversation
Sets default widget height and width to 100% Consolidates some css Removes unused mdk-creator.css
… Development Kit' to 'Materia Widget Development Kit'.
…ve updated all of them.
* MSCA upgraded to v2.0.0-alpha1 * postinstall and build tasks will no longer build msca assets
update to node 12
Update name references.
Issue/45 helper markdown
…-ids Make sure empty question and answer IDs have values.
Makes player height 0 scale like materia server does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran it on a few widgets, everything still seems to be installing and building properly.
Seems fine to me.
Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1. - [Release notes](https://github.com/joyent/node-sshpk/releases) - [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.16.1)
Bump sshpk from 1.13.1 to 1.16.1
…-install-to-materia-button Issue/54 materia ifrit broke the install to materia button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with multiple widgets, including the new helper documentation and those that rely on polyfills. Everything looks OK to me. I think it's ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from some widgets' coffeescript appearing to compile differently, which is just going to have to be resolved per widget, everything seems to be good - the only thing I can see is that there are requests to files that don't appear to exist any more. The creator is referencing a mwdk-creator.css
which doesn't appear to exist (and manifests as a MIME type error, somehow), and the player tries looking up a main.css
which has the same problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving with new changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old file references are gone, looks like everything works.
Approved.
Includes: