Fixes for the brokers package #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we gracefully handle a cancellation call for IsAuthorized, we need to wait for the routine to return and close the done channel when CancelIsAuthorized is called, otherwise it just progresses the main routine without waiting for the expected values.
The previous calls for IsAuthorized and CancelIsAuthorized were using CallWithContext, which would associate the specified context with the calls. Since we rely on context cancelation to properly cancel the IsAuthorized operation on the Broker, we can't use the same context on the dbus call as it would result in the whole call being cancelled. Now they use Call instead, which uses context.Backgroung() by default.
GabrielNagy
approved these changes
Aug 4, 2023
didrocks
requested changes
Aug 4, 2023
This allows us to use the examplebroker on the brokers package without having issues with import cycles.
In order to be able to continue using the examplebroker locally, some methods need to be public in order to be accessed in the brokers package
When moving examplebroker to a new package, the creation of those brokers got affected and they were being created with an empty interface that couldn't be used for tests. Now they are examplebrokers.
The function dbus.ConnectSystemBus() does exactly the same thing we were doing by using dbus.PrivateSystemBus() and then having to manually Auth and Hello, so it's better to use the ConnectSystemBus() one.
denisonbarbosa
force-pushed
the
fixes-for-broker-package
branch
from
7c1e3e8
to
5f2740a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing the tests, some problems emerged that demanded some fixing.
The details of each individual fix are contained in the commit messages.