fix(pam/integration-tests/gdm): Handle broker selection when on such stage #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
gdm-tests-broker-selection-race
branch
3 times, most recently
from
2f51fec
to
edd7cdd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 82.99% 83.04% +0.05%
==========================================
Files 80 80
Lines 8584 8589 +5
Branches 75 75
==========================================
+ Hits 7124 7133 +9
+ Misses 1129 1126 -3
+ Partials 331 330 -1 ☔ View full report in Codecov by Sentry. |
denisonbarbosa
requested changes
Nov 7, 2024
denisonbarbosa
approved these changes
Nov 12, 2024
We have some races in gdm tests caused by the fact we may send the brokerSelection event too late, in particular when we received the broker list, but at that point we may be have done other steps already. Instead, handle the broker selection only when we're in broker selection stage, and not too early or too late.
3v1n0
force-pushed
the
gdm-tests-broker-selection-race
branch
from
205df3c
to
48db852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some races in gdm tests caused by the fact we may send the
brokerSelectedevent too late, in particular when we received thebroker list, but at that point we may be have done other steps already.
Instead, handle the broker selection only when we're in broker selection
stage, and not too early or too late.