Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First round of housekeeping #5

Merged
merged 4 commits into from
Jul 28, 2023
Merged

First round of housekeeping #5

merged 4 commits into from
Jul 28, 2023

Conversation

denisonbarbosa
Copy link
Member

@denisonbarbosa denisonbarbosa commented Jul 28, 2023 •
edited
Loading

Addressing some linter and CI issues in our codebase and updating .gitignore

@denisonbarbosa denisonbarbosa requested a review from a team as a code owner July 28, 2023 13:35
@denisonbarbosa denisonbarbosa changed the title Housekeeping pt. 1 First round of housekeeping Jul 28, 2023
didrocks
didrocks approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, that will help review the other PR! Let’s get that in once you fix the 2 minor comments.

internal/brokers/examplebroker.go Show resolved Hide resolved
internal/brokers/localbroker.go Outdated Show resolved Hide resolved
@denisonbarbosa
Addressing linter issues on our codebase
af1fd96
@denisonbarbosa
Updating qa.yaml to install apt dependencies
42109f7
@denisonbarbosa
Update go:generate to add required flag for protoc
27da932 
Optional fields are currently experimental, so we need to add a flag to
protoc when compiling .proto files that use optional fields.
@denisonbarbosa denisonbarbosa force-pushed the housekeeping branch 2 times, most recently from 7f3a9f5 to 27da932 Compare July 28, 2023 14:40
@denisonbarbosa denisonbarbosa merged commit 9b8aa4c into main Jul 28, 2023
2 of 3 checks passed
@denisonbarbosa denisonbarbosa deleted the housekeeping branch July 28, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didrocks didrocks didrocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denisonbarbosa @didrocks