Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Fingerprint unlock: backoff time between retries #443

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

Flohack74
Copy link
Member

Currently Lomiri would try to read a fingerprint, and upon failure immediately retry, giving the user no chance to lift the finger. Also 3 retries is quite too low.
Implement a timer-based backoff that allows the user to correct finger position more easily, and also increase the max failed retries to 5.

@Flohack74
Copy link
Member Author

Note that this PR introduces a change in behaviour (hence the changes to unit tests): When the fingerprint unlocking method is locked after 5 consecutive failures we no longer automatically emulate the swipe to get to the PIN or password input. I think this is very confusing.
In a second PR we will move up the hint text a bit from the very bottom, and also show a symbol if fingerprint scanner can be used or not.

@Flohack74 Flohack74 force-pushed the xenial_-_fpreader-awesome branch from b343b25 to 73953a1 Compare July 11, 2022 18:20
@j2g2rp
Copy link
Contributor

j2g2rp commented Jul 12, 2022

I've been testing this for last day on Volla x. Looks like Fingerprint reader works fine now.

@amartinz
Copy link
Member

amartinz commented Jul 14, 2022

In a second PR we will move up the hint text a bit from the very bottom, and also show a symbol if fingerprint scanner can be used or not.

Is that plan documented somewhere trackable?

@Flohack74
Copy link
Member Author

@amartinz yes currently here: #447

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants