Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Always hide launcher in lock screen #378

Open
wants to merge 1 commit into
base: xenial
Choose a base branch
from

Conversation

kugiigi
Copy link
Contributor

@kugiigi kugiigi commented Apr 19, 2021

This hides the launcher in lock screen even with desktop mode enabled and auto-hide disabled.

This hides the launcher in lock screen even with desktop mode enabled and auto-hide disabled.
@cibersheep
Copy link
Contributor

What's the idea behind this?

Is not System Settings > Lock & Unlock > Launcher -> off enough?

@kugiigi
Copy link
Contributor Author

kugiigi commented Apr 19, 2021

No, when in desktop mode and launcher auto-hide is disabled, the launcher is shown even in lock screen.
Regardless of the value set in System Settings > Lock & Unlock > Launcher.
And in my opinion, the launcher should be hidden in lock screen anyway.

@cibersheep
Copy link
Contributor

Ah, I didn't understand it. It's clear now. Thanks

Copy link
Member

@UniversalSuperBox UniversalSuperBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  1. File an issue report giving steps how to reproduce this problem
  2. Find a way to reproduce the problem in Lomiri's test suite. The test should fail without your changes.
  3. Apply your changes and ensure they fix the problem as stated. Commit the test and the changes in the same commit, or add the test in a second commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants