Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Enable greeter rotation on landscape devices #373

Closed
wants to merge 1 commit into from

Conversation

kugiigi
Copy link
Contributor

@kugiigi kugiigi commented Apr 15, 2021

This will enable rotation of the lock screen on devices with landscape as their primary orientation. Rotation is limited on the two landscape orientations since the greeter does not yet have responsive design. This is helpful on tablets since users may use the tablet in either landscape orientations especially when using a magnetic case that can be folded as stand.

@cibersheep
Copy link
Contributor

Oh, I forgot I started this: #315
Missing: phones, with desktop mode on, fails to show Infographic... we could hide it then

@kugiigi
Copy link
Contributor Author

kugiigi commented Apr 15, 2021

Yeah, I've seen the other PRs related to greeter rotation but none seem to be ready yet. I was planning to contact the authors of those PR and check if there has been updates or if I can help :)

In any case, this PR is just a quick solution, specially useful for tablets (and for me :D), which can be implemented until full rotation is supported.

@cibersheep
Copy link
Contributor

I understand. Ideally would be greeter to rotate on all devices that supports all orientations.

I need to clean, rebase, revise and finish my draft. All help is welcome ^_^

This will enable rotation of the lock screen on devices with landscape as their primary orientation. Rotation is limited on the two landscape orientations since the greeter does not yet have responsive design.
@kugiigi kugiigi force-pushed the xenial_-_greeterrotate branch from 20b5404 to f14527d Compare April 16, 2021 09:31
@Fuseteam
Copy link
Contributor

is this still needed now #402 has been merged?

@kugiigi
Copy link
Contributor Author

kugiigi commented Jan 24, 2022

is this still needed now #402 has been merged?

Well I guess not really needed anymore . Thanks for the heads up

@kugiigi kugiigi closed this Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants