Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lenovo X605: 20.04: updated config for compatibility with focal builds #252

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Lenovo X605: 20.04: updated config for compatibility with focal builds #252

merged 1 commit into from
Mar 8, 2024

Conversation

luksus42
Copy link
Contributor

@luksus42 luksus42 commented Feb 8, 2024

  • added hint for 2GB/16GB models
  • fixed links to to gitlab community-ports
  • updated boot.img and checksum
  • removed after_install hint, which is not necessary anymore

@luksus42 luksus42 requested a review from NeoTheThird as a code owner February 8, 2024 18:50
@luksus42
Copy link
Contributor Author

luksus42 commented Feb 8, 2024

@maciek134 , just pinging you on behalf for the maintainers, since NeoTheThird is not active anymore...

maciek134
maciek134 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@maciek134 maciek134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though I don't have the device so can't test it fully

@maciek134
Copy link
Contributor

We also seem to have a broken CI...

@luksus42
Copy link
Contributor Author

luksus42 commented Feb 9, 2024

yeah, I am not sure what the issue is about, I don't believe that it has something to do with my commit...

@amartinz
Copy link
Member

Without the CI getting fixed, any changes merged will be "ignored", as deployment fails to run.

@amartinz amartinz merged commit 5cf5c67 into ubports:master Mar 8, 2024
1 check passed
@luksus42
Copy link
Contributor Author

luksus42 commented Mar 8, 2024

Hey, thanks for bringing things forward here.

@amartinz
Copy link
Member

amartinz commented Mar 8, 2024

Thanks to you for fixing the CI and having lots of patience :)

@luksus42 luksus42 deleted the Lenovo-X605 branch March 24, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciek134 maciek134 maciek134 approved these changes

@NeoTheThird NeoTheThird Awaiting requested review from NeoTheThird NeoTheThird is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luksus42 @maciek134 @amartinz