Feature/format contracts prettier plugin solidity

[gitcoindev]

Resolves #839

• enforce prettier-plugin-solidity for packages/contracts solidity files
• improve format:all
• upgrade prettier-plugin-solidity to 1.2.0

Plus fix prettier output for IUbiquityGovernance.sol

[ubiquibot]

60bf159

60bf159

[molecula451]

Please, provide QA, which pattern is following?

[gitcoindev]

Please, provide QA, which pattern is following?

@molecula451 sure, please check the QA demo below: I am changing one contract, one test file, two places each and prettier is fixing the layout during pre-commit stage.

prettier_qa_demo.mp4

[rndquu]

[0x4007]

@molecula451 sure, please check the QA demo below: I am changing one contract, one test file, two places each and prettier is fixing the layout during pre-commit stage.

prettier_qa_demo.mp4

That's crazy to me that you're using vim without syntax highlighting.

For future reference, you do not need to request a review from me in this repository as most of the work involves Solidity and I am not a Solidity expert.

[0x4007]

To be honest I couldn't make much sense of what exactly was happening in your video, but the code seems fine.

[gitcoindev]

@molecula451 sure, please check the QA demo below: I am changing one contract, one test file, two places each and prettier is fixing the layout during pre-commit stage.
prettier_qa_demo.mp4

That's crazy to me that you're using vim without syntax highlighting.

🤣

For future reference, you do not need to request a review from me in this repository as most of the work involves Solidity and I am not a Solidity expert.

All right, will remember that. You were set as a default when I opened the pull request.

[gitcoindev]

Merging with 2 approvals.

[molecula451]

@gitcoindev please, wait for my full review as I am working on other sections of the repo

[gitcoindev]

All right, though this one was already closed. Fortunately you should be able to easily rebase your branch on top of development as it does not affect existing code much and should not change anything in your pull request.

[molecula451]

no worries, but the best ideal is to have everyones feedback before it gets merged, unless! and unless! the implementation is absolutely clear to everyones eyes