Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): apply diamond architecture to the credits page #823

Merged
merged 27 commits into from
Oct 16, 2023
Merged

feat(ui): apply diamond architecture to the credits page #823

merged 27 commits into from
Oct 16, 2023

Conversation

bojan07
Copy link
Contributor

@bojan07 bojan07 commented Oct 16, 2023

Resolves #786

bojan07 and others added 25 commits October 2, 2023 02:01
@bojan07
feat: apply diamond to home page
b1b2bc2
@bojan07
fix: added debug option to refreshPrices function
dd22fa0
@bojan07
fix: make code clean in use-prices
b2bbdca
@bojan07
Merge branch 'ubiquity:development' into development
510e7a2
@bojan07
feat: used protocol-contracts in use-balances and use-named-contracts
8da767d
@bojan07
feat: applied protocol-contracts to child components of staking page
b3a3856
@bojan07
fix: fixed build error and made code clean in use-balances
5e1a071
@bojan07
fix: used non-null assertion operator for object null checking
f5ac79b
@bojan07
fix: added metapool and governancemarket contract to protocol-contrac…
18ee556 
…ts to avoid invalid hook call
@bojan07
chore: cleamake use-protocol-contracts clean
9ad50ee
@bojan07
fix: applied new name convention
1ce1d35
@bojan07
fix: object null checking
57bc6e1
@bojan07
fix: cleaned refresh balance function
6972f9c
@bojan07
fix: hardcoded some addresses and fixed prefetch-constants function
61ee7f7
@bojan07
fix: checking big number zero value
eb6e495
@bojan07
fix: non-null assertion operator and infinite hook loop
88c1b46
@bojan07
Merge branch 'ubiquity:development' into development
8edb930
@bojan07
fix: contract type in allowance functions
9e07817
@bojan07
Merge branch 'ubiquity:development' into development
de99518
@bojan07
fix: passed hardcoded addresses as variable
e7dc29f
@bojan07
fix: updated variable names according to new name convention
c086a17
@bojan07
fix: match contract type according to diamond architecture
cd4ce71
@bojan07
Merge branch 'ubiquity:development' into development
80cacf2
@bojan07
Merge branch 'ubiquity:development' into development
89cb8f4
@bojan07
fix: removed protocolcontracts in dependencies to avoid infinite loop
d4e4185
@ubiquibot
Copy link

ubiquibot bot commented Oct 16, 2023 •
edited
Loading

rndquu
rndquu approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was basically solved as a part of this PR.

There is still the network error when you open the credits page but it is not related to the diamond refactoring.

@rndquu rndquu requested a review from molecula451 October 16, 2023 21:53
@molecula451 molecula451 merged commit 8c446fa into ubiquity:development Oct 16, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndquu rndquu rndquu approved these changes

@molecula451 molecula451 Awaiting requested review from molecula451

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: apply diamond to credits page
3 participants
@bojan07 @rndquu @molecula451