Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: update eslint flag #811

Merged
merged 5 commits into from
Oct 9, 2023
Merged

linter: update eslint flag #811

merged 5 commits into from
Oct 9, 2023

Conversation

molecula451
Copy link
Member

Resolves #810

QA:
null

@molecula451 molecula451 requested a review from rndquu October 7, 2023 17:25
@ubiquibot
Copy link

ubiquibot bot commented Oct 7, 2023

@molecula451 molecula451 changed the title update cspell linter: update cspell Oct 7, 2023
@rndquu
Copy link
Member

rndquu commented Oct 9, 2023

I don't understand the purpose of this code change. I tried both with and without the "!" symbol in the cspell.json file and it doesn't affect the build.

We already have the non-null assertion rule enabled hence the warnings are shown. What we should do is to throw an error if there are some warnings produced by eslint so that the CI build failed with error. This line could be updated to eslint --fix --max-warnings=0 (more info)

@molecula451 molecula451 marked this pull request as draft October 9, 2023 09:09
@molecula451
Copy link
Member Author

molecula451 commented Oct 9, 2023

lmao, well the thing is i rarely use ! in the code, and always fix my code to eslint errors i thought that was why the warning pop by updating the cspell.json will have to recheck that a bit

so basically the contributor ignored the warning, we should have updated to a fail/error instead

@molecula451 molecula451 marked this pull request as ready for review October 9, 2023 09:37
@molecula451
Copy link
Member Author

i think --max-warnings=0 is approachable so we keep it simple and fix errors when eslint pop em up

@molecula451 molecula451 changed the title linter: update cspell linter: update eslint flag Oct 9, 2023
@rndquu rndquu merged commit 17e79d3 into ubiquity:development Oct 9, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbid specific non-null assertion
2 participants