Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drosera integration #979

Open
rndquu opened this issue Dec 9, 2024 · 20 comments · May be fixed by #981
Open

Drosera integration #979

rndquu opened this issue Dec 9, 2024 · 20 comments · May be fixed by #981

Comments

@rndquu
Copy link
Member

rndquu commented Dec 9, 2024

We should add https://www.drosera.io testnet support.

What should be done:

  1. Deploy ubiquity protocol contracts to the testnet
  2. Create a trap which should pause protocol contracts in case there's a security incident
  3. Make sure the trap actually works (i.e. pauses ubiquity contracts) by triggering conditions leading to trap execution
@rndquu
Copy link
Member Author

rndquu commented Dec 9, 2024

@zugdev FYI

@zugdev
Copy link
Contributor

zugdev commented Dec 9, 2024

Great!

@kingsley-einstein
Copy link

/start

Copy link

ubiquity-os bot commented Dec 16, 2024

! This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: Priority: 3 (High), Priority: 4 (Urgent), Priority: 5 (Emergency)

Copy link

ubiquity-os bot commented Dec 17, 2024

@kingsley-einstein the deadline is at Wed, Dec 18, 7:39 AM UTC

Copy link

ubiquity-os bot commented Dec 17, 2024

Important

  • Be sure to link a pull-request before the first reminder to avoid disqualification.
  • Reminders will be sent every 7 days if there is no activity.
  • Assignees will be disqualified after 14 days of inactivity.

kingsley-einstein added a commit to kingsley-einstein/ubiquity-dollar that referenced this issue Dec 17, 2024
@kingsley-einstein kingsley-einstein linked a pull request Dec 17, 2024 that will close this issue
@kingsley-einstein
Copy link

@rndquu
I'm running into some problems here. It turns out some of the submodules have been updated on their source repos. Is it okay to update the code that depends on them or should I leave it as is? The task depends on them being up to date.

@rndquu
Copy link
Member Author

rndquu commented Dec 18, 2024

The task depends on them being up to date.

What exactly requires updated submodules?

@kingsley-einstein
Copy link

The task depends on them being up to date.

What exactly requires updated submodules?

@rndquu
Deploying to the testnet. The trap contract has been written already, and I need to test that it works.

@rndquu
Copy link
Member Author

rndquu commented Dec 18, 2024

The task depends on them being up to date.

What exactly requires updated submodules?

@rndquu Deploying to the testnet. The trap contract has been written already, and I need to test that it works.

How exactly deploying to testnet requires updated submodules?

@kingsley-einstein
Copy link

The task depends on them being up to date.

What exactly requires updated submodules?

@rndquu Deploying to the testnet. The trap contract has been written already, and I need to test that it works.

How exactly deploying to testnet requires updated submodules?

@rndquu
Artifacts are first generated for the contracts before actual deployment. Forge throws an error when the deployment script is run as it is unable to load the required submodules because they've been updated, and they're not imported as they should.

@rndquu
Copy link
Member Author

rndquu commented Dec 18, 2024

it is unable to load the required submodules because they've been updated

I don't understand. All submodules use exact branches. The lib folder contains exact commits of the submodules. We don't need to update anything.

@kingsley-einstein
Copy link

kingsley-einstein commented Dec 18, 2024

@rndquu
Some of the imported contracts have been moved or removed from their sources. This is what I mean:
Screenshot from 2024-12-18 15-11-47

Checking the lib folder after pulling the submodules, I notice some of the utilized contracts are nowhere to be found.

@rndquu
Copy link
Member Author

rndquu commented Dec 18, 2024

@rndquu Some of the imported contracts have been moved or removed from their sources. This is what I mean: Screenshot from 2024-12-18 15-11-47

Checking the lib folder after pulling the submodules, I notice some of the utilized contracts are nowhere to be found.

Both contracts are in place:

It seems there's smth wrong with your local setup. Make sure foundry installs libraries from exact branches, not the latest ones.

@kingsley-einstein
Copy link

@rndquu
Alright!

@kingsley-einstein
Copy link

@rndquu
I keep running into a "TrapCreatorNotWhitelisted" error while deploying a trap. Do I need to reach out to be whitelisted by the Drosera team? The doc doesn't mention that as a requirement to create a trap.

@rndquu
Copy link
Member Author

rndquu commented Dec 23, 2024

@rndquu I keep running into a "TrapCreatorNotWhitelisted" error while deploying a trap. Do I need to reach out to be whitelisted by the Drosera team? The doc doesn't mention that as a requirement to create a trap.

@zugdev Help

@zugdev
Copy link
Contributor

zugdev commented Dec 23, 2024

@rndquu I keep running into a "TrapCreatorNotWhitelisted" error while deploying a trap. Do I need to reach out to be whitelisted by the Drosera team? The doc doesn't mention that as a requirement to create a trap.

@zugdev Help

I've reached out to them, will probably need some info in a sec.

@zugdev
Copy link
Contributor

zugdev commented Dec 23, 2024

@kingsley-einstein fill this pls https://x8em3g9nvrn.typeform.com/to/vV90O6Aw

@kingsley-einstein
Copy link

@zugdev That has been filled already. What am I supposed to do next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants