feat: add notifications UI #1
Conversation
|
@rndquu could you please increase the auth token expiry date in supabase? |
|
@zugdev pull tag here |
@0x4007 I could hide mention with no comments, or specific types and still allow review requested, either whitelist or blacklist types if thats interesting to you. rn I have hidden the no comment notifs |
|
I just want the notifications view that GitHub provides but to exclude the following:
That would cut out almost all of the noise. |
lmk when u test it out |
|
Confused why there's so many now.
You can see the scroll bar on the right to approximate how many. Also when the comment loads in sync it jitters the row and looks bad. set the row height to be static so this doesn't happen. |
|
@0x4007 instead of fixed height I totally fixed jitters by prefetching comments and then rendering about the inbox message size. yes, it is weird, but if u try the api yourself sometimes in github stuff is marked as read but the api doesnt say so. also, I've diffed upstream and there is nothing different about the title |
|
Posting a shortcut to the deploys because GitHub iOS client makes it extremely tedious to get to |
That should be fine
This is obviously a problem that needs to be fixed for this tool to be useful. Also these just started all loading in since the last few changes you made so I'm inclined to believe that the problem was introduced based on recent changes.
The html order matters for the checkbox which is clearly rendering. Look for any css code selectors using
|
|
9520dfc is the last good one |
|
5c95353 loads too many notifications |
|
You need to review your work before requesting reviews again |
|
alright, mb. all should be fixed rn |
|
Looks good I just wish I had more notifications, but I just finished reviewing everything! @gentlementlegen @whilefoo @rndquu @EresDev can you guys take a look at the latest deploy and offer feedback based on your notifications? |
|
In other news, I wanted to share that the noise from the bot will be mostly mitigated once this is implemented |
Is the caching implemented correctly? 
|
|
yup, u can check console to better find the reasons but in approval/funding UI there isnt a comment, instead its a requested change. all the closed PRs and issues dont show. also try toggling show bot. perhaps we should switch the show bot toggle for show all (related to ubiquity of course) |
|
alright I've added logs on every notification hiden, u can open console to see the reason, this will allow us to finetune and decide what should go through over time as well |
Resolves ubiquity-os/.github#1