test(storage-workflow): should pass if core / diamond storage is chan…

…ged without collision
ubiquity · Oct 17, 2024 · f8b5c3f · f8b5c3f
1 parent ad8b124
commit f8b5c3f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/contracts/src/dollar/core/ERC20Ubiquity.sol b/packages/contracts/src/dollar/core/ERC20Ubiquity.sol
@@ -25,8 +25,10 @@ abstract contract ERC20Ubiquity is
     ERC20PermitUpgradeable,
     ERC20PausableUpgradeable
 {
+    // this is a non-colliding change
+
     /// @notice Token symbol
-    string private test; // _symbol
+    string private _symbol;
 
     /// @notice Access control interface
     IAccessControl public accessControl;

diff --git a/packages/contracts/src/dollar/libraries/LibAppStorage.sol b/packages/contracts/src/dollar/libraries/LibAppStorage.sol
@@ -7,8 +7,10 @@ import "./Constants.sol";
 
 /// @notice Shared struct used as a storage in the `LibAppStorage` library
 struct AppStorage {
+    // this is a non-colliding change
+
     // reentrancy guard
-    uint256 test; //reentrancyStatus
+    uint256 reentrancyStatus;
     // others
     address dollarTokenAddress;
     address creditNftAddress;