chore: fix slither warning

ubiquity · Sep 11, 2024 · 42f592e · 42f592e
1 parent 29c2ea5
commit 42f592e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/packages/contracts/lib/aave-v3-core b/packages/contracts/lib/aave-v3-core
diff --git a/packages/contracts/lib/aave-v3-periphery b/packages/contracts/lib/aave-v3-periphery
diff --git a/packages/contracts/src/dollar/core/UbiquityAMOMinter.sol b/packages/contracts/src/dollar/core/UbiquityAMOMinter.sol
@@ -101,17 +101,17 @@ contract UbiquityAMOMinter is Ownable {
     ) external validAMO(msg.sender) {
         int256 collat_amt_i256 = int256(collat_amount);
 
-        // Receive first
+        // First, update the balances
+        collat_borrowed_balances[msg.sender] -= collat_amt_i256;
+        collat_borrowed_sum -= collat_amt_i256;
+
+        // Then perform transfer from
         collateral_token.safeTransferFrom(
             msg.sender,
             address(pool),
             collat_amount
         );
 
-        // Then update the balances
-        collat_borrowed_balances[msg.sender] -= collat_amt_i256;
-        collat_borrowed_sum -= collat_amt_i256;
-
         emit CollateralReceivedFromAMO(msg.sender, collat_amount);
     }