Fix:Log-app code seperated and github workflow is assigned

[baibhavKumar1]

Resolves #712
Don't merge before creation of new "log-app" repo.

1. Creating a new repo is beyond my access for this org. Once the repo is created by owner, I can add the log-app folder to new repository.
2. Log-app and ubiquibot code has been seperated.
3. Workflow is assigned accordingly.

[netlify]

✅ Deploy Preview for ubiquibot-staging ready!

Name	Link
🔨 Latest commit	a4679b2
🔍 Latest deploy log	https://app.netlify.com/sites/ubiquibot-staging/deploys/650144377a396800086da0ce
😎 Deploy Preview	https://deploy-preview-727--ubiquibot-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[0x4007]

I created the repository for you. Please feel free to introduce changes via a pull request there!

https://github.com/ubiquity/ubiquibot-logging

[baibhavKumar1]

I created the repository for you. Please feel free to introduce changes via a pull request there!

https://github.com/ubiquity/ubiquibot-logging

Thanks, on it ser.

[baibhavKumar1]

@pavlovcik any idea, where "Fetcher" in https://github.com/ubiquity/ubiquibot/blob/development/log-app/types/global.ts is coming from, and "request" in https://github.com/ubiquity/ubiquibot/blob/development/log-app/_worker.ts ?

[rndquu]

@pavlovcik any idea, where "Fetcher" in https://github.com/ubiquity/ubiquibot/blob/development/log-app/types/global.ts is coming from, and "request" in https://github.com/ubiquity/ubiquibot/blob/development/log-app/_worker.ts ?

I guess those types are coming from this line. Log app uses a separate tsconfig so perhaps your IDE fetches the bot's tsconfig instead of the log app's one hence there are typescript errors in the IDE.

[rndquu]

@Wholesomebruh

So this PR creates the log app in a separate repo.

What about removing the log app from the bot's code? Is it implemented?

[baibhavKumar1]

It will be removed only after log-app is added to the logging repo, as there are few issues like #676 that will be adding changes to log-app . I will coordinate with contributer/hunter at time of final commit , if they want me to wait and add their changes also or they will make contribution to logging repo later. In this PR, there is log-app has no code connected with ubiquibot repo (other than .deployment file which is dependent on previous action.

[rndquu]

It will be removed only after log-app is added to the logging repo, as there are few issues like #676 that will be adding changes to log-app . I will coordinate with contributer/hunter at time of final commit , if they want me to wait and add their changes also or they will make contribution to logging repo later.

I don't understand why we should wait for #676. This issue will be simply transferred to the https://github.com/ubiquity/ubiquibot-logging repo and solved there.

In this PR, there is log-app has no code connected with ubiquibot repo (other than .deployment file which is dependent on previous action.

This whole folder is a log app inside the bot's code. So this folder (along with related code) should be removed from the https://github.com/ubiquity/ubiquibot repo.

[0xcodercrane]

I don't understand about the changes.

1/ Why do we want to deploy log-app to cloudflare in ubiquibot repo? -- doesn't make sense. It should be in the same repository: ubiquity/ubiquibot-logging

2/ I guess that's fine to remove log-app folder and relevant stuff from ubiquibot.

As a issue creator, would you @rndquu give me better understanding?

[rndquu]

1/ Why do we want to deploy log-app to cloudflare in ubiquibot repo? -- doesn't make sense. It should be in the same repository: ubiquity/ubiquibot-logging

Yes, it should be in a separate repo as stated in the issue's description

2/ I guess that's fine to remove log-app folder and relevant stuff from ubiquibot.

Yes, it is also stated in the issue's description

As a issue creator, would you @rndquu give me better understanding?

I don't know what else to add :)

[whilefoo]

closing due to inactivity