-
Notifications
You must be signed in to change notification settings - Fork 61
chore: merged repo and org config #691
chore: merged repo and org config #691
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it wasn't clear, the spec is to have nested inheritance for the entire config, not just for incentives. Ideally I'd like to get rid of every function in helpers.ts
and just merge repo, org and default config using lodash - that way we don't need to keep adding new functions for every property.
we can get the nested inheritance for the entire config without using the lodash simply like this.
What's the benefit to use lodash here? @whilefoo |
that would work only for top-level properties not nested, example: https://jsfiddle.net/8qhbj7r2/ |
Got that, I'm pushing a new commit with helpers function removed and lodash used in merging all objs |
All configs merged: one-two-test/one#3 (comment) |
Co-authored-by: whilefoo <[email protected]>
Co-authored-by: whilefoo <[email protected]>
@devpanther please resolve conflicts |
resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #648
QA: one-two-test/one#3