-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
i might have not done everything fully, if yes, please let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Pls refactor param names to kebab case, example:
first-time-contributer-greeting-help-menu
- The
first-time-contributer-greeting-footer
param is missing - Pls fix the spelling
contributer => contributor
This is missing a QA. Please add a QA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
QA is failing @EtherealGlow plz link an QA issue where you show it works and explain the exact scenarios in which the bot will generate this reply |
This "first time contributor" message should be displayed literally in response to the 1st bounty hunter's comment in a repo This QA tries to get the "first time contributor" message for So to QA the current issue we need a fresh account without any comments. |
oops |
accidentally pushed to wrong branch |
Resolves #96