Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

feat: add first time configs #581

Closed
wants to merge 1 commit into from
Closed

feat: add first time configs #581

wants to merge 1 commit into from

Conversation

EtherealGlow
Copy link
Contributor

Resolves #96

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit 8249115
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/64d7364cd8df8300083e2c07
😎 Deploy Preview https://deploy-preview-581--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EtherealGlow
Copy link
Contributor Author

i might have not done everything fully, if yes, please let me know

Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Pls refactor param names to kebab case, example: first-time-contributer-greeting-help-menu
  2. The first-time-contributer-greeting-footer param is missing
  3. Pls fix the spelling contributer => contributor

@EtherealGlow EtherealGlow requested a review from rndquu August 5, 2023 05:12
@web4er
Copy link
Contributor

web4er commented Aug 8, 2023

This is missing a QA. Please add a QA.

rndquu
rndquu previously approved these changes Aug 9, 2023
0x4007
0x4007 previously approved these changes Aug 9, 2023
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@Draeieg
Copy link
Contributor

Draeieg commented Aug 11, 2023

QA is failing @EtherealGlow

plz link an QA issue where you show it works and explain the exact scenarios in which the bot will generate this reply

@rndquu
Copy link
Member

rndquu commented Aug 12, 2023

QA is failing @EtherealGlow

plz link an QA issue where you show it works and explain the exact scenarios in which the bot will generate this reply

This "first time contributor" message should be displayed literally in response to the 1st bounty hunter's comment in a repo

This QA tries to get the "first time contributor" message for devtestubq account but this is not the 1st message of devtestubq. This account had already posted messages earlier.

So to QA the current issue we need a fresh account without any comments.

@EtherealGlow EtherealGlow dismissed stale reviews from 0x4007 and rndquu via 8249115 August 12, 2023 07:35
@EtherealGlow
Copy link
Contributor Author

oops

@EtherealGlow
Copy link
Contributor Author

accidentally pushed to wrong branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add first time contributor message
5 participants