-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@me505 please make a draft PR if its not ready to review |
@0xcodercrane can you review this and tell me if i missing something |
I am not sure about the spec. handing it off to @pavlovcik if you have some time. Please merge if its good |
@pavlovcik any updates on this? |
@0xcodercrane do we have comment incentives working already? because I don't see a way to test this without those |
Its not yet. From the codebase changes, I don't think |
Reading the initial spec given I thought this would be including the multi comment permits Therefore in order for me to do proper testing I needed those things working, otherwise we might encounter weird behaviors but it seems this is only solving a small part of the spec viewing the actual code changes and the Preview isn't showing any significant changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree @Draeieg without being able to pay out multiple contributors for a closed issue, I don't see how this is testable.
The purpose of this feature is to allow the bot to post a comment to pay out multiple contributors. Furthermore the design has been changed to hide the details per contributor payout unless it's clicked on.
So even from the comment markdown/html code, this task is not completed.
Resolves #375