Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

feat: permit design #518

Closed
wants to merge 6 commits into from
Closed

Conversation

BeanieMen
Copy link
Contributor

Resolves #375

@BeanieMen BeanieMen requested a review from 0xcodercrane as a code owner July 16, 2023 22:21
@netlify
Copy link

netlify bot commented Jul 16, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit e9ec9dc
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/64b6784ac8cd050007fc9425
😎 Deploy Preview https://deploy-preview-518--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0xcodercrane
Copy link
Contributor

@me505 please make a draft PR if its not ready to review

@BeanieMen BeanieMen marked this pull request as draft July 17, 2023 06:19
@BeanieMen BeanieMen marked this pull request as ready for review July 17, 2023 07:52
@BeanieMen
Copy link
Contributor Author

@0xcodercrane can you review this and tell me if i missing something

@0xcodercrane
Copy link
Contributor

I am not sure about the spec. handing it off to @pavlovcik if you have some time. Please merge if its good

@BeanieMen
Copy link
Contributor Author

@pavlovcik any updates on this?

@Draeieg
Copy link
Contributor

Draeieg commented Jul 28, 2023

@0xcodercrane do we have comment incentives working already? because I don't see a way to test this without those

@0xcodercrane
Copy link
Contributor

0xcodercrane commented Jul 28, 2023

@0xcodercrane do we have comment incentives working already? because I don't see a way to test this without those

Its not yet. From the codebase changes, I don't think comment incentives issue is kind of a blocker for the QA. please fix me if I am missing something here.

@Draeieg
Copy link
Contributor

Draeieg commented Jul 30, 2023

@0xcodercrane do we have comment incentives working already? because I don't see a way to test this without those

Its not yet. From the codebase changes, I don't think comment incentives issue is kind of a blocker for the QA. please fix me if I am missing something here.

Reading the initial spec given I thought this would be including the multi comment permits Therefore in order for me to do proper testing I needed those things working, otherwise we might encounter weird behaviors

but it seems this is only solving a small part of the spec viewing the actual code changes and the Preview isn't showing any significant changes

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @Draeieg without being able to pay out multiple contributors for a closed issue, I don't see how this is testable.

The purpose of this feature is to allow the bot to post a comment to pay out multiple contributors. Furthermore the design has been changed to hide the details per contributor payout unless it's clicked on.

So even from the comment markdown/html code, this task is not completed.

@ubiquibot ubiquibot bot closed this Jul 30, 2023
@ubiquibot ubiquibot bot mentioned this pull request Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Multi Permit Comment Design
4 participants