Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync branch to template #321

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Sync branch to template #321

merged 6 commits into from
Oct 8, 2024

Conversation

ubiquity-os[bot]
Copy link
Contributor

@ubiquity-os ubiquity-os bot commented Oct 1, 2024

This pull request merges changes from the template repository.

@ubiquity-os ubiquity-os bot requested a review from Keyrxng as a code owner October 1, 2024 00:35
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Unused devDependencies (2)

Filename devDependencies
package.json @mswjs/data
@types/jest

Unlisted dependencies (32)

Filename unlisted
globals.d.ts ethereum-protocol
static/scripts/rewards/app-state.ts @ethersproject/providers
@ubiquibot/permit-generation/types
@ubiquity-dao/rpc-handler
static/scripts/rewards/cirip/query-reverse-ens.ts ethers
static/scripts/rewards/render-transaction/insert-table-data.ts @ubiquibot/permit-generation/types
ethers
static/scripts/rewards/render-transaction/read-claim-data-from-url.ts @supabase/supabase-js
@ubiquibot/permit-generation/handlers
@ubiquibot/permit-generation/types
static/scripts/rewards/render-transaction/render-token-symbol.ts ethers
static/scripts/rewards/render-transaction/render-transaction.ts @ubiquibot/permit-generation/types
@ubiquity-dao/rpc-handler
static/scripts/rewards/web3/add-network.ts ethers
@ubiquity-dao/rpc-handler
static/scripts/rewards/web3/connect-wallet.ts @ethersproject/providers
ethers
static/scripts/rewards/web3/erc20-permit.ts @ethersproject/providers
@ubiquibot/permit-generation/types
ethers
@ubiquity-dao/rpc-handler
static/scripts/rewards/web3/erc721-permit.ts @ethersproject/providers
@ubiquibot/permit-generation/types
ethers
static/scripts/rewards/web3/not-on-correct-network.ts ethers
@ubiquity-dao/rpc-handler
static/scripts/rewards/web3/switch-network.ts ethers
static/scripts/rewards/web3/use-rpc-handler.ts @ubiquity-dao/rpc-handler
static/scripts/rewards/web3/verify-current-network.ts ethers
cypress/e2e/claim-portal-failure.cy.ts @ethersproject/providers
cypress/e2e/claim-portal-success.cy.ts @ethersproject/providers
ethers

Unlisted binaries (4)

Filename binaries
.github/workflows/cypress-testing.yml test:anvil
test:fund
.github/workflows/deploy.yml start:sign
.github/workflows/generate-permit.yml start:sign

@Keyrxng
Copy link
Contributor

Keyrxng commented Oct 2, 2024

okay I'm gonna try handle this

@Keyrxng
Copy link
Contributor

Keyrxng commented Oct 2, 2024

I've removed from the PR what's not needed and kept everything else but the tests have broken for some reason

image

I've been debugging for the past hour. cy.fixture() happens inside the setup functions, cy.wait() happens after everything is setup and even with it removed I get other errors. This is unchanged since we stabilized tests/CI for this repo. The most recent CI runs have passed and I even reverted to the development cypress version instead of the one that came with this PR, I can't explain it right now but will continue to debug.

@0x4007 0x4007 merged commit c98b958 into development Oct 8, 2024
5 of 6 checks passed
@0x4007 0x4007 deleted the sync-template/development branch October 8, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants