Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Carousel #320

Closed

Conversation

pbkompasz
Copy link
Contributor

Resolves #196

@pbkompasz pbkompasz requested a review from Keyrxng as a code owner September 29, 2024 14:51
@pbkompasz pbkompasz changed the title new pr Vertical Carousel Sep 29, 2024
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Sep 29, 2024

Copy link
Contributor

Preview Deployment
5109769f05fffd3655e513f5a1556ec742ea0624

@pbkompasz pbkompasz marked this pull request as draft September 29, 2024 14:57
@pbkompasz pbkompasz force-pushed the feat/rewrite-transactions branch from 5109769 to 7beaaaf Compare September 29, 2024 15:01
@Keyrxng
Copy link
Contributor

Keyrxng commented Sep 30, 2024

@pbkompasz is this ready for review or are still to make changes?

@pbkompasz
Copy link
Contributor Author

@Keyrxng I have to look over it again. I will let you know when it's ready.

@Keyrxng
Copy link
Contributor

Keyrxng commented Oct 1, 2024

No worries, thanks

@pbkompasz pbkompasz marked this pull request as ready for review October 10, 2024 00:12
@pbkompasz
Copy link
Contributor Author

@Keyrxng It's ready.

@rndquu rndquu self-requested a review October 11, 2024 08:27
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-11 at 11 45 19

There's smth strange with URLs, there're js objects and undefined values in href attribute

@rndquu rndquu marked this pull request as draft October 11, 2024 08:49
@pbkompasz
Copy link
Contributor Author

@rndquu So both of those issues come from the @ubiquity-dao/rpc-handler package. There is also another issue that I ran into where the getFastestRpcProvider fails to create a provider.
Is there a way for me to take a look at the codebase? I cannot seem to find a repo only the npm package.
These bugs are also present in production
Screenshot from 2024-10-14 23-13-04

@0x4007
Copy link
Member

0x4007 commented Oct 14, 2024

I'm going to be migrating it soon to a different RPC manager. I'm still just finalizing it. You're welcome to give it a try since I'll probably need at least a few more days to get around to integrating it into this codebase. My plan was to manually copy and paste the essential files here but soon create a new npm module.

@Keyrxng
Copy link
Contributor

Keyrxng commented Oct 15, 2024

If we standardized using blockscan.com/ instead of trying to pull explorers based on network, these href obj issues would be resolved. networks like 31337 etc may not have explorer/chains listed (even in rpc-handler v1.3 with the thousands of collected explorers it has collected). We have already relied on blockscan and it's proven v useful as it supports all 20+ Permit2 networks that we use, since we only support Permit2 networks anyway.

functions likes getNetworkExplorer() etc should just be www.blockscan.com/ not explorers[net] ?? "www.blockscan.com/"

@rndquu rndquu mentioned this pull request Oct 16, 2024
@0x4007 0x4007 closed this in #341 Oct 16, 2024
@0x4007 0x4007 reopened this Oct 16, 2024
@0x4007 0x4007 closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redo Carousel
4 participants