Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update readme #318

Merged
merged 3 commits into from
Sep 26, 2024
Merged

chore: update readme #318

merged 3 commits into from
Sep 26, 2024

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Sep 24, 2024

Resolves #317

This is a simple edit as the DB is not required for 99% of feature requests. Unless you think it's necessary to also include DB schema.

@Keyrxng Keyrxng requested a review from 0x4007 September 24, 2024 14:52
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are long h1 headers you sure you want to do it that way?

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 24, 2024

Those are long h1 headers you sure you want to do it that way?

https://github.com/ubq-testing/pay.ubq.fi/blob/development/README.md

It's inside a code block so it's standard comment syntax

@0x4007
Copy link
Member

0x4007 commented Sep 25, 2024

Great can you make sure that the entire readme is up to date with everything that needs to be there beyond just Supabase if anything? Then you can merge thanks.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 26, 2024

I can't think of anything else that it needs really beyond the /beta branch info but that's handled on that branch.

@Keyrxng Keyrxng merged commit 45b345a into ubiquity:development Sep 26, 2024
3 checks passed
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 26, 2024

I added the legacy env vars NONCE and NONCE_SIGNER_ADDRESS which are used in the invalidation script but that's not used anymore is it? Or is that how you invalidate permits still?

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Sep 26, 2024

Copy link
Contributor

github-actions bot commented Sep 26, 2024

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 26, 2024

The reason we only have two previews instead of three here is because the first hit a bad gateway error which is unrelated to the current CI deployment issue.

Further confused by it because it appeared like core team could deploy, but whilefoo's last two attempt against /beta failed similar to other contributors. It only seems to work for me, you and rndquu...

@0x4007
Copy link
Member

0x4007 commented Sep 26, 2024

rndquu just fixed it yesterday so hopefully we see more reliability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update readme with correct env vars
2 participants