Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: truncated long ENS names #304

Closed
wants to merge 1 commit into from
Closed

fix: truncated long ENS names #304

wants to merge 1 commit into from

Conversation

hydroxylase
Copy link
Contributor

Resolves #237

@hydroxylase
Copy link
Contributor Author

@0x4007 @gentlementlegen If you'll be so kind to review my changes

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing the logic in ChatGPT, it seems like you're just adding the ellipse at the end if its longer than 42 characters, but this is better implemented in CSS so that its dynamic to the table width.

@hydroxylase
Copy link
Contributor Author

I'm testing the logic in ChatGPT, it seems like you're just adding the ellipse at the end if its longer than 42 characters, but this is better implemented in CSS so that its dynamic to the table width.

I'm all for @Keyrxng approach to this problem by string manipulation. An Ethereum Address is 42 characters long and it normally gets rendered. Now because ENS names can be longer than 42 characters as mentioned by one of moderators if truncating the ENS name in case it exceeds 42 characters an adding the ellipsis otherwise it gets fully rendered

@hydroxylase hydroxylase deleted the responsive branch September 14, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive issues on long recipient's name
2 participants