-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Unit tests for virtual cards backend #288
Conversation
Unused devDependencies (3)
Unlisted dependencies (3)
Unresolved imports (1)
|
@Keyrxng |
@EresDev would know better for this particular task, but yeah I assume so looking at the script but various other factors might have changed so I'm unsure personally. |
Maybe because this is missing networkId in permit parameters? Line 54 in 1e9a074
Plus, I also think it needs token approval and a few other steps. Something similar to what happens in yarn test:fund command.
Is it worth having all this anvil setup in backend unit tests? It is already present in e2e tests. Did you consider just mocking the blockchain? I think it is worth considering mocking the blockchain. In fact, we don't even change the state of blockchian in the backend, and it can make things much simpler. |
Resolves #271