fix: optimal RPC now removes faulty elements properly #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that the app requires a wallet connected to show anything now. This is undesirable behavior. I wonder if these changes somehow affected this. I wrapped the image below in an anchor so you can see for yourself. Perhaps it's an issue with when the permit is parsed.
|
|
@pavlovcik Not sure if this is related but eventually could be, I guess it is not possible to see the logs via mobile. But if you didn't get any toast with an error it should not come from here as the only case where it remains at loading state is when no RPC is found at all (with an error toast). I will test on my phone then. Can you redeem or just see the details of the reward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #205
It worked during the tests because the faulty network was https://gnosis.api.onfinality.io/public. It so happens that there is a similar network at https://gnosis.api.onfinality.io/public_100. I didn't see that the ID of the network would be removed from the key in such case, leading to a
deleteof a key that actually didn't exist during the loop. This has been fixed by storing the untrimmed key in another variable to actually remember the real key value.