Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove blacklist #179

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore: remove blacklist #179

merged 1 commit into from
Feb 27, 2024

Conversation

molecula451
Copy link
Member

@molecula451 molecula451 commented Feb 27, 2024

Resolves ubiquity/rpc-handler#3

Working locally, follows pattern matching commited by pavlovcik last week, and purge the blacklist thing by the commiter

yarn utils:build
yarn start

localhost testing

@molecula451 molecula451 marked this pull request as ready for review February 27, 2024 02:56
@molecula451 molecula451 requested a review from 0x4007 as a code owner February 27, 2024 02:56
@molecula451 molecula451 requested a review from rndquu February 27, 2024 02:56
@ubiquity-os-deployer
Copy link

@0x4007
Copy link
Member

0x4007 commented Feb 27, 2024

I'm skeptical about this implementation because I expected it to be a lot more involved.

I vaguely recall it being a lot more complicated to have it remember the performance ranking of the RPCs and then to use the top RPC for subsequent calls.

Perhaps that wasn't clearly defined in the spec though so as long as this is stable (will need to run a stress test @FernandVEYRIER maybe with cypress?) then this deliverable should be acceptable.

@molecula451
Copy link
Member Author

molecula451 commented Feb 27, 2024

absolutely this only takes in charge in removing the blacklist addition, it does not implements the whole dynamic pick the RPC, you can still merge it without closing the issue if it doesn't meet, tho

@0x4007
Copy link
Member

0x4007 commented Feb 27, 2024

Oh I see unless you open the pull request with the correct body, it will not link it to the issue. Edits don't count

@0x4007 0x4007 merged commit 6713c16 into ubiquity:main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants