-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub 1s loading UI #169
Merged
Merged
Sub 1s loading UI #169
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
35d0b99
feat: call db to retrieve permits instead of parsing github
gentlementlegen 7528f3e
chore: issue number now uses the value from git get request
gentlementlegen 2b21d66
Merge branch 'development' into permit-urls-from-db
655ead5
chore: fixed merged characters
gentlementlegen 72b23f2
Merge remote-tracking branch 'origin/development' into permit-urls-fr…
gentlementlegen 3b7c3d2
Merge remote-tracking branch 'pay.ubiquity/development' into permit-u…
gentlementlegen 2f11234
chore: merged development branch
gentlementlegen 0878552
chore: added Action secrets to the build.yml
gentlementlegen f5e3a80
feat: sub 1s load time
Keyrxng ebd54e1
fix: conflicts
Keyrxng 7fab1b4
chore: fetch inside try
Keyrxng f1ca988
feat: sub 1s load time
Keyrxng 97fb13c
chore: fetch inside try
Keyrxng 2adf64b
fix: revert and pull from head
Keyrxng a1c6e4b
chore: renamed supabase key to SUPABASE_PUBLIC_ANON_KEY
gentlementlegen 0ba50af
chore: renamed supabase key to SUPABASE_ANON_KEY
gentlementlegen 5a504fd
chore: allow personal repo to be searched
gentlementlegen ba87b12
chore: renamed supabase env variables
gentlementlegen 53ab0ec
Merge pull request #164 from FernandVEYRIER/permit-urls-from-db
0x4007 b592128
Merge branch 'fix/perf' into development
0x4007 c0249df
Merge branch 'ubiquity:development' into speed-improvements
Keyrxng 517dd48
fix: use allnetworkurls
Keyrxng 1fe025d
fix: rpc blacklist
Keyrxng fd9a8e5
fix: continuous deploys
0x4007 24284bd
Merge pull request #176 from pavlovcik/fix/cd
0x4007 6f3bfdf
Merge branch 'ubiquity:development' into speed-improvements
Keyrxng 16a534e
fix: no network resolved
Keyrxng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { generateERC20Permit } from "./generate-permit2-url"; | ||
import { log, verifyEnvironmentVariables } from "./utils"; | ||
|
||
export async function generateMultiERC20Permits() { | ||
for (let i = 0; i < 5; i++) { | ||
const url = await generateERC20Permit(); | ||
log.ok("Testing URL:"); | ||
console.log(url); | ||
} | ||
} | ||
|
||
generateMultiERC20Permits().catch((error) => { | ||
console.error(error); | ||
verifyEnvironmentVariables(); | ||
process.exitCode = 1; | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This blacklist idea doesn't seem like a robust approach. We can merge it in but it should be handled dynamically. I think I implemented this in an unstable manner on my branch, I vaguely recall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the issue is that the claim button flickers on a failure then finding out why exactly that's happening because of a failed background call would probs be the best way to handle it I guess, otherwise just try{}catch() and don't log the error? seems hacky we could care less if one or two calls have failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because the CSS/style logic is implemented poorly. I tore it apart in my refactor but didn't get to put it all together in a totally stable way (mostly the other RPC related functions- I believe the styling code was significantly simplified and stable if I recall correctly).
Unfortunately I'm running very low on code time because I'll need to focus on fundraising starting next week. So I'm just going to be focusing on top priority stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Luckily for me I've got nothing but code time, regretfully it does eventually require that you have review time lmao but I'll keep on pushing forward with things as best I can in the meantime, cheers for the heads up