Claims Broken

[0x4007]

When starting from Ethereum mainnet, and having to switch, the RPC stays broken until localStorage is cleared.

• On the production instance da14f1b claims don't work with the following error:

erc20-permit.ts:259 Error in nonceBitmap method:  Error: could not detect network (event="noNetwork", code=NETWORK_ERROR, version=providers/5.7.2)
    at _Logger.makeError (index.ts:269:28)
    at _Logger.throwError (index.ts:281:20)
    at JsonRpcProvider.<anonymous> (json-rpc-provider.ts:483:23)
    at Generator.throw (<anonymous>)
    at rejected (index.ts:373:5)
(anonymous) @ erc20-permit.ts:259
Promise.catch (async)
isNonceClaimed @ erc20-permit.ts:258
checkPermitClaimable @ erc20-permit.ts:134
checkPermitClaimability @ erc20-permit.ts:49
claimErc20PermitHandler @ erc20-permit.ts:109
erc20-permit.ts:136 Error in isNonceClaimed:  Error: could not detect network (event="noNetwork", code=NETWORK_ERROR, version=providers/5.7.2)
    at _Logger.makeError (index.ts:269:28)
    at _Logger.throwError (index.ts:281:20)
    at JsonRpcProvider.<anonymous> (json-rpc-provider.ts:483:23)
    at Generator.throw (<anonymous>)
    at rejected (index.ts:373:5)

[0x4007]

Update: cleared my RPC cache and its fine. It must have selected a bad RPC. Perhaps the new module by Keyrxng handles this? Can you confirm @Keyrxng?

[ubiquibot]

# Issue was not closed as completed. Skipping.

[0x4007]

Update again: when starting from Ethereum mainnet, and having to switch, the RPC stays broken until localStorage is cleared.

[Keyrxng]

I'm pretty sure that #204 resolves this, I'll add specific QA into the PR shortly

[Keyrxng]

I've linked the because it relates to it but 204 resolves it, should I update 204 body and link this issue?

[0x4007]

We can make an exception but I left a comment in my review explaining my preference.

[0x4007]

@gentlementlegen do you think you can push a fix for this before the conference?

[gentlementlegen]

@pavlovcik Can have a look for sure. It was mentioned just above that another PR might solve it? How is this going?

[0x4007]

Its with another untested dependency thats not used currently in this repository.

[gentlementlegen]

/start

[ubiquibot]

Deadline	Sun, Mar 24, 6:25 AM UTC
Registered Wallet	0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED

Tips:

• Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
• Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
• Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

[gentlementlegen]

@pavlovcik So far what I found it that it happens with only one specific RPC which is https://gnosis.api.onfinality.io/public . So it is actually not necessarily linked to switching networks but just happens if this specific one gets selected. It works fine with others like https://gnosis-mainnet.public.blastapi.io or https://rpc.ankr.com/gnosis

I am not sure of the fix yet, maybe retry with other networks if it happens, or there is a way to check that prior to sending the requests. I'll test @Keyrxng PR just in case to see if it is resolved that way, otherwise will investigate for a fix.

[Keyrxng]

Before I made rpc-handlerpackage, I had implemented a very rudimentary solution which was a manual blacklist filtering bad RPCS pre-build because like you say, there are few that need removed, I'm pretty sure there was at least 2 RPCs that would fail consistently from the list if I remember right

It got hastily removed without being replaced with another solution immediately, so yeah if you don't want to involve another package then could always use this approach considering the urgency and band-aid style solve that's needed

const blacklist = ["https://xdai-archive.blockscout.com", "https://gnosis.api.onfinality.io/public"];

Are the two I had, reverting the below commit will solve the issue without trying to over-engineer something that'll be replaced by the rpc-handler package when that goes live

https://github.com/ubiquity/pay.ubq.fi/pull/179/files

[ubiquibot]

+ Evaluating results. Please wait...

[ubiquibot]

[ 85 WXDAI ]

@pavlovcik

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	37
Issue	Comment	5	17.6
Review	Comment	3	30.4

Conversation Incentives

Comment	Formatting	Relevance	Reward
When starting from Ethereum mainnet, and having to switch, the R...	37 li: count: 1 score: "1" words: 21 code: count: 1 score: "1" words: 0	1	37
Update: cleared my RPC cache and its fine. It must have selected...	5.4	0.8	5.4
Update again: when starting from Ethereum mainnet, and having to...	3.8	0.99	3.8
We can make an exception but I left a comment in my review expla...	3.2	0.605	3.2
@gentlementlegen do you think you can push a fix for this before...	2.8	0.79	2.8
Its with another untested dependency thats not used currently in...	2.4	0.785	2.4
> I sadly can only get a screenshot for the QA since there is no...	10	0.85	10
I'm not sure if there are any pitfalls with the built in RPC pro...	9.2	0.8	9.2
I think the api is standardized. It's like `window.ethereum.sign...	11.2 code: count: 2 score: "4" words: 7	0.805	11.2

[ 170.3 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	125
Issue	Comment	2	0
Issue	Comment	2	13.3
Review	Comment	2	16
Review	Comment	2	16

Conversation Incentives

Comment	Formatting	Relevance	Reward
@pavlovcik Can have a look for sure. It was mentioned just above...	-	0.825	-
@pavlovcik So far what I found it that it happens with only one ...	-	0.755	-
@pavlovcik Can have a look for sure. It was mentioned just above...	2.2	0.825	2.2
@pavlovcik So far what I found it that it happens with only one ...	11.1	0.755	11.1
I sadly can only get a screenshot for the QA since there is no t...	6.6	0.74	6.6
> > I sadly can only get a screenshot for the QA since there is ...	9.4	0.79	9.4
I sadly can only get a screenshot for the QA since there is no t...	6.6	0.74	6.6
> > I sadly can only get a screenshot for the QA since there is ...	9.4	0.79	9.4

[ 19.85 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	3	19.85

Conversation Incentives

Comment	Formatting	Relevance	Reward
I'm pretty sure that #204 resolves this, I'll add specific QA in...	1.7	0.885	1.7
I've linked the because it relates to it but `204` resolves it, ...	2.7 code: count: 2 score: "0.5" words: 2	0.695	2.7
Before I made `rpc-handler`package, I had implemented a very rud...	15.45 code: count: 3 score: "0.75" words: 4	0.87	15.45

[Keyrxng]

ty :))

The original blacklist was required because any failed rpc calls was spazzing the UI which I believe you caught @pavlovcik when you redone things, can't see it happening anymore the way it was before

[0x4007]

@gentlementlegen just wanted to update and say that this is not reliable. I can't claim from my phone anymore, and when I refresh from desktop it seems to be about 50% chance of working. Can you try manually testing some more?

[0x4007]

[gentlementlegen]

@pavlovcik thanks for the logs. It seems that it keeps retrying with that network that was failing all the time somehow. Maybe a case where this network is always the quickest one and gets put back in the list first always, very annoying use case that I most likely didn't happen. Will fix.

[ubiquibot]

+ Evaluating results. Please wait...

[ubiquibot]

[ 102.4 WXDAI ]

@pavlovcik

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	37
Issue	Comment	7	30
Review	Comment	4	35.4

Conversation Incentives

Comment	Formatting	Relevance	Reward
When starting from Ethereum mainnet, and having to switch, the R...	37 li: count: 1 score: "1" words: 21 code: count: 1 score: "1" words: 0	1	37
Update: cleared my RPC cache and its fine. It must have selected...	5.4	0.81	5.4
Update again: when starting from Ethereum mainnet, and having to...	3.8	0.885	3.8
We can make an exception but I left a comment in my review expla...	3.2	0.615	3.2
@gentlementlegen do you think you can push a fix for this before...	2.8	0.69	2.8
Its with another untested dependency thats not used currently in...	2.4	0.725	2.4
@gentlementlegen just wanted to update and say that this is not ...	8.4	0.73	8.4
> I sadly can only get a screenshot for the QA since there is no...	10	0.86	10
I'm not sure if there are any pitfalls with the built in RPC pro...	9.2	0.79	9.2
I think the api is standardized. It's like `window.ethereum.sign...	11.2 code: count: 2 score: "4" words: 7	0.785	11.2
@gentlementlegen just wanted to confirm that this fix works and ...	5	0.915	5

[ 175.7 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	125
Issue	Comment	3	0
Issue	Comment	3	18.7
Review	Comment	2	16
Review	Comment	2	16

Conversation Incentives

Comment	Formatting	Relevance	Reward
@pavlovcik Can have a look for sure. It was mentioned just above...	-	0.72	-
@pavlovcik So far what I found it that it happens with only one ...	-	0.82	-
@pavlovcik thanks for the logs. It seems that it keeps retrying ...	-	0.775	-
@pavlovcik Can have a look for sure. It was mentioned just above...	2.2	0.72	2.2
@pavlovcik So far what I found it that it happens with only one ...	11.1	0.82	11.1
@pavlovcik thanks for the logs. It seems that it keeps retrying ...	5.4	0.775	5.4
I sadly can only get a screenshot for the QA since there is no t...	6.6	0.75	6.6
> > I sadly can only get a screenshot for the QA since there is ...	9.4	0.755	9.4
I sadly can only get a screenshot for the QA since there is no t...	6.6	0.75	6.6
> > I sadly can only get a screenshot for the QA since there is ...	9.4	0.755	9.4

[ 33.5 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	4	23.45
Review	Comment	1	10.05

Conversation Incentives

Comment	Formatting	Relevance	Reward
I'm pretty sure that #204 resolves this, I'll add specific QA in...	1.7	0.835	1.7
I've linked the because it relates to it but `204` resolves it, ...	2.7 code: count: 2 score: "0.5" words: 2	0.71	2.7
Before I made `rpc-handler`package, I had implemented a very rud...	15.45 code: count: 3 score: "0.75" words: 4	0.655	15.45
ty :)) The original blacklist was required because any faile...	3.6	0.665	3.6
it's standardized across providers and if multiple are used then...	10.05 code: count: 1 score: "0.25" words: 1	0.845	10.05

[0x4007]

@rndquu the deploys seem to have an issue again https://github.com/ubiquity/pay.ubq.fi/actions/runs/8439604631/job/23114576421#step:2:142

I re-ran it and its okay so this seems to be some intermittent issue.