feat: better naming

ubiquity · Dec 21, 2024 · f801b95 · f801b95
1 parent b5c844a
commit f801b95
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/static/handle-approval.ts b/static/handle-approval.ts
@@ -38,7 +38,7 @@ function isValidAmount(): boolean {
   return isValid;
 }
 
-export function isApprovalValid() {
+export function isApprovalButtonsValid() {
   const isConnected = appState.getIsConnectedState();
   const isAddressValid = isValidAddress();
   const isAmountValid = isValidAmount();
@@ -107,7 +107,7 @@ async function onApproveClick() {
     renderErrorInModal(error as Error);
   } finally {
     approveButton.textContent = originalText;
-    isApprovalValid(); // re-check the state to restore buttons correctly
+    isApprovalButtonsValid(); // re-check the state to restore buttons correctly
   }
 }
 
@@ -141,11 +141,11 @@ async function onRevokeClick() {
     renderErrorInModal(error as Error);
   } finally {
     revokeButton.textContent = originalText;
-    isApprovalValid(); // re-check state to restore buttons correctly
+    isApprovalButtonsValid(); // re-check state to restore buttons correctly
   }
 }
 
-export function setupValidityListener() {
-  amountInput.addEventListener("change", isApprovalValid);
-  addressInput.addEventListener("change", isApprovalValid);
+export function setupButtonValidityListener() {
+  amountInput.addEventListener("change", isApprovalButtonsValid);
+  addressInput.addEventListener("change", isApprovalButtonsValid);
 }
diff --git a/static/main.ts b/static/main.ts
@@ -3,8 +3,8 @@ import { Ethers5Adapter } from "@reown/appkit-adapter-ethers5";
 import { anvil, gnosis, mainnet, polygon, optimism, arbitrum, base, bsc, blast, zksync, avalanche, worldchain, AppKitNetwork } from "@reown/appkit/networks";
 import { ethers } from "ethers";
 import { renderErrorInModal } from "./display-popup-modal";
-import { updateTokens } from "./populate-dropdown";
-import { isApprovalValid, setupApproveButton, setupRevokeButton, setupValidityListener } from "./handle-approval";
+import { updateTokenDropdown } from "./populate-dropdown";
+import { isApprovalButtonsValid, setupApproveButton, setupRevokeButton, setupButtonValidityListener } from "./handle-approval";
 
 // all unhandled errors are caught and displayed in a modal
 window.addEventListener("error", (event: ErrorEvent) => renderErrorInModal(event.error));
@@ -90,8 +90,8 @@ async function initializeProviderAndSigner() {
   }
 
   // update UI elements that depend on connection state
-  isApprovalValid();
-  updateTokens();
+  isApprovalButtonsValid();
+  updateTokenDropdown();
 }
 
 function handleNetworkSwitch() {
@@ -111,10 +111,10 @@ function handleNetworkSwitch() {
 
 export async function mainModule() {
   try {
-    setupValidityListener(); // setup amount and token validity listeners
-    updateTokens(); // update known tokens on the dropdown
-    setupApproveButton(); // setup approve button
-    setupRevokeButton(); // setup revoke button
+    setupButtonValidityListener();
+    updateTokenDropdown();
+    setupApproveButton();
+    setupRevokeButton();
     handleNetworkSwitch();
 
     // initialize for the first time

diff --git a/static/populate-dropdown.ts b/static/populate-dropdown.ts
@@ -12,7 +12,7 @@ const tokensByNetwork: { [key: number]: { [token: string]: string } } = {
 const tokenSelector = document.querySelector(".token-selector") as HTMLInputElement;
 const tokenOptions = document.querySelector("#token-options") as HTMLSelectElement;
 
-export function updateTokens() {
+export function updateTokenDropdown() {
   const networkId = Number(appState.getChainId());
 
   let tokens = {};