fix: prevent deploy to production on open PR #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like @rndquu and I are busy with other urgent projects. This also seems pretty urgent so we can test in production? @ubiquity/software-development heads up if things break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8
QA
It does not affect the normal operations of a fork. A fork's change on the
developmentbranch (or whatever the default branch is) gets deployed to production. All other branches get deployed to preview.Action: https://github.com/EresDevOrg/3rd-fork-pay.ubq.fi/actions/runs/8526016642/job/23355077672
When a fork opens a pull request to the ubiquity's
developmentbranch, it gets deployed to Cloudflare preview.Action: https://github.com/EresDevOrg/pay.ubq.fi/actions/runs/8526313017/job/23355279324
PR: https://github.com/EresDevOrg/pay.ubq.fi/pull/14
When the pull request is merged, it gets deployed to the production.
Action: https://github.com/EresDevOrg/pay.ubq.fi/actions/runs/8526347581/job/23355387087
PR: https://github.com/EresDevOrg/pay.ubq.fi/pull/14